Skip to content

Enable sidecar on 8.3#2716

Merged
pierotibou merged 4 commits intomasterfrom
revert-2700-pierre/disable-on-83
Jun 26, 2024
Merged

Enable sidecar on 8.3#2716
pierotibou merged 4 commits intomasterfrom
revert-2700-pierre/disable-on-83

Conversation

@pierotibou
Copy link
Copy Markdown
Collaborator

@pierotibou pierotibou commented Jun 17, 2024

Reverts #2700

This will allow us to have more monitoring on changes we will work on in the coming weeks.

@pierotibou pierotibou requested a review from a team as a code owner June 17, 2024 12:32
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.94%. Comparing base (5869a12) to head (c1b2449).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2716      +/-   ##
============================================
+ Coverage     77.83%   77.94%   +0.11%     
  Complexity     2212     2212              
============================================
  Files           227      227              
  Lines         26599    26599              
  Branches        988      988              
============================================
+ Hits          20703    20733      +30     
+ Misses         5370     5340      -30     
  Partials        526      526
Flag Coverage Δ
appsec-extension 69.13% <ø> (ø)
tracer-extension 78.81% <ø> (+0.22%) ⬆️
tracer-php 80.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
ext/configuration.h 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5869a12...c1b2449. Read the comment docs.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Jun 17, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-06-26 10:44:36

Comparing candidate commit c1b2449 in PR branch revert-2700-pierre/disable-on-83 with baseline commit 5869a12 in branch master.

Found 4 performance improvements and 0 performance regressions! Performance is the same for 174 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline

  • 🟩 execution_time [-18.099µs; -14.277µs] or [-9.503%; -7.497%]

scenario:PDOBench/benchPDOOverhead

  • 🟩 execution_time [-16.998µs; -14.560µs] or [-5.858%; -5.018%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟩 execution_time [-17.868µs; -16.117µs] or [-5.663%; -5.108%]

scenario:SamplingRuleMatchingBench/benchRegexMatching2-opcache

  • 🟩 execution_time [-321.243ns; -140.157ns] or [-4.647%; -2.027%]

@hoolioh hoolioh force-pushed the revert-2700-pierre/disable-on-83 branch from d507d41 to 768ec98 Compare June 26, 2024 07:47
@pierotibou pierotibou merged commit 505623f into master Jun 26, 2024
@pierotibou pierotibou deleted the revert-2700-pierre/disable-on-83 branch June 26, 2024 11:19
@github-actions github-actions Bot added this to the 1.2.0 milestone Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamluc iamluc iamluc approved these changes

@hoolioh hoolioh hoolioh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@pierotibou @codecov-commenter @iamluc @hoolioh