Skip to content

Update to maintain compatibility with libdatadog#2661

Merged
bwoebi merged 1 commit intomasterfrom
bob/update-libdatadog
May 13, 2024
Merged

Update to maintain compatibility with libdatadog#2661
bwoebi merged 1 commit intomasterfrom
bob/update-libdatadog

Conversation

@bwoebi
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi commented May 12, 2024

Description

Rename in sidecar from interface to service.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@bwoebi bwoebi requested review from a team as code owners May 12, 2024 22:25
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 12, 2024

Benchmarks

Benchmark execution time: 2024-05-13 14:33:51

Comparing candidate commit adda776 in PR branch bob/update-libdatadog with baseline commit d60b961 in branch master.

Found 5 performance improvements and 0 performance regressions! Performance is the same for 173 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline

  • 🟩 execution_time [-18.013µs; -17.097µs] or [-9.409%; -8.930%]

scenario:PDOBench/benchPDOOverhead

  • 🟩 execution_time [-15.529µs; -7.115µs] or [-5.375%; -2.463%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟩 execution_time [-18.750µs; -16.618µs] or [-6.023%; -5.338%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3-opcache

  • 🟩 execution_time [-445.459ns; -160.741ns] or [-6.911%; -2.494%]

scenario:SamplingRuleMatchingBench/benchRegexMatching4-opcache

  • 🟩 execution_time [-449.871ns; -249.729ns] or [-6.983%; -3.876%]

@bwoebi
Copy link
Copy Markdown
Collaborator Author

bwoebi commented May 12, 2024

Needs DataDog/libdatadog#425 first & cbindgen run.

@iamluc
Copy link
Copy Markdown
Contributor

iamluc commented May 13, 2024

@bwoebi bwoebi force-pushed the bob/update-libdatadog branch from 85a9bee to adda776 Compare May 13, 2024 14:06
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 13, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.63%. Comparing base (d60b961) to head (5af0596).
⚠️ Report is 917 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2661      +/-   ##
============================================
- Coverage     79.18%   77.63%   -1.56%     
  Complexity     2208     2208              
============================================
  Files           199      225      +26     
  Lines         22019    26036    +4017     
  Branches          0      988     +988     
============================================
+ Hits          17435    20212    +2777     
- Misses         4584     5298     +714     
- Partials          0      526     +526     
Flag Coverage Δ
appsec-extension 69.13% <ø> (?)
tracer-extension 78.46% <100.00%> (ø)
tracer-php 80.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ext/telemetry.c 98.91% <100.00%> (ø)

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d60b961...5af0596. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bwoebi bwoebi force-pushed the bob/update-libdatadog branch from adda776 to 5af0596 Compare May 13, 2024 14:21
@bwoebi bwoebi merged commit 3d5be50 into master May 13, 2024
@bwoebi bwoebi deleted the bob/update-libdatadog branch May 13, 2024 14:42
@bwoebi bwoebi added this to the 1.0.0 milestone May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants