Skip to content

build(profiling): update to libdatadog v7#2605

Merged
morrisonlevi merged 1 commit intomasterfrom
levi/prof-libdatadog-v7
Mar 29, 2024
Merged

build(profiling): update to libdatadog v7#2605
morrisonlevi merged 1 commit intomasterfrom
levi/prof-libdatadog-v7

Conversation

@morrisonlevi
Copy link
Copy Markdown
Collaborator

@morrisonlevi morrisonlevi commented Mar 29, 2024

Description

Upgrades from libdatadog v6 to v7.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@morrisonlevi morrisonlevi requested review from a team as code owners March 29, 2024 15:36
@github-actions github-actions Bot added the profiling Relates to the Continuous Profiler label Mar 29, 2024
bwoebi
bwoebi approved these changes Mar 29, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming CI passes :-)

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 29, 2024

Benchmarks

Benchmark execution time: 2024-03-29 15:43:01

Comparing candidate commit c2eb219 in PR branch levi/prof-libdatadog-v7 with baseline commit 7169ff4 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 3 unstable metrics.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 29, 2024 •
edited
Loading

Codecov Report

Merging #2605 (c2eb219) into master (7169ff4) will increase coverage by 1.11%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2605      +/-   ##
============================================
+ Coverage     75.52%   76.64%   +1.11%     
  Complexity     2603     2603              
============================================
  Files           242      216      -26     
  Lines         27277    23278    -3999     
  Branches        985        0     -985     
============================================
- Hits          20601    17841    -2760     
+ Misses         6151     5437     -714     
+ Partials        525        0     -525
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.71% <ø> (ø)
tracer-php 74.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 26 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7169ff4...c2eb219. Read the comment docs.

@morrisonlevi
Copy link
Copy Markdown
Collaborator Author

morrisonlevi commented Mar 29, 2024

Most of the test failures were discussed, and are pending this branch: https://github.com/DataDog/dd-trace-php/compare/bob/fix-asan-leak.

The parametric test failure seems unrelated to this PR, but is probably worth calling out.

@morrisonlevi morrisonlevi merged commit e670e76 into master Mar 29, 2024
@morrisonlevi morrisonlevi deleted the levi/prof-libdatadog-v7 branch March 29, 2024 19:07
@github-actions github-actions Bot added this to the 0.99.0 milestone Mar 29, 2024
realFlowControl added a commit that referenced this pull request Apr 4, 2024
@realFlowControl
Revert "build(profiling): update to libdatadog v7 (#2605)"
3dbd00c 
This reverts commit e670e76.
@realFlowControl realFlowControl mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebi bwoebi bwoebi approved these changes

@danielsn danielsn danielsn approved these changes

Assignees

No one assigned

Labels

profiling Relates to the Continuous Profiler

Projects

None yet

Milestone

0.99.0

Development

Successfully merging this pull request may close these issues.

4 participants

@morrisonlevi @codecov-commenter @bwoebi @danielsn