Skip to content

Make Laravel appsec login success event more accurate#2600

Merged
estringana merged 1 commit intomasterfrom
estringana/improve-login-success-laravel-event
Mar 28, 2024
Merged

Make Laravel appsec login success event more accurate#2600
estringana merged 1 commit intomasterfrom
estringana/improve-login-success-laravel-event

Conversation

@estringana
Copy link
Copy Markdown
Contributor

@estringana estringana commented Mar 28, 2024 •
edited
Loading

Description

It has been reported that the previous approach to trigger successful logins is not accurate. This results on some endpoints reporting successful login events on every request instead of just when a user gets logged in into the system. This PR attach the event to the event provided by Laravel

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 28, 2024 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.90%. Comparing base (3d4313f) to head (fc98f13).
⚠️ Report is 811 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2600   +/-   ##
=========================================
  Coverage     76.90%   76.90%           
  Complexity     2564     2564           
=========================================
  Files           215      215           
  Lines         23095    23095           
=========================================
+ Hits          17761    17762    +1     
+ Misses         5334     5333    -1
Flag Coverage Δ
tracer-extension 78.66% <ø> (+<0.01%) ⬆️
tracer-php 74.73% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ations/Integrations/Laravel/LaravelIntegration.php 81.90% <100.00%> (ø)

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d4313f...fc98f13. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 28, 2024

Benchmarks

Benchmark execution time: 2024-03-28 09:41:16

Comparing candidate commit fc98f13 in PR branch estringana/improve-login-success-laravel-event with baseline commit 3d4313f in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 181 metrics, 0 unstable metrics.

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-13.487µs; -10.413µs] or [-7.245%; -5.594%]

@estringana estringana marked this pull request as ready for review March 28, 2024 10:57
@estringana estringana requested a review from a team as a code owner March 28, 2024 10:57
@estringana estringana requested a review from Anilm3 March 28, 2024 10:57
Anilm3
Anilm3 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

PROFeNoM
PROFeNoM approved these changes Mar 28, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@PROFeNoM PROFeNoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🛥️

@estringana estringana merged commit c993b6a into master Mar 28, 2024
@estringana estringana deleted the estringana/improve-login-success-laravel-event branch March 28, 2024 11:35
@github-actions github-actions Bot added this to the 0.99.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Anilm3 Anilm3 Anilm3 approved these changes

@PROFeNoM PROFeNoM PROFeNoM approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.99.0

Development

Successfully merging this pull request may close these issues.

4 participants

@estringana @codecov-commenter @Anilm3 @PROFeNoM