Skip to content

Allow hooking an inherited internal constructor#2591

Merged
bwoebi merged 1 commit into
masterfrom
bob/fix-internal-inherited-ctor
Mar 25, 2024
Merged

Allow hooking an inherited internal constructor#2591
bwoebi merged 1 commit into
masterfrom
bob/fix-internal-inherited-ctor

Conversation

@bwoebi

@bwoebi bwoebi commented Mar 22, 2024

Copy link
Copy Markdown
Collaborator

Description

Internal constructors are edge cases and need to be handled explicitly.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@bwoebi
bwoebi requested a review from a team as a code owner March 22, 2024 14:27
@codecov-commenter

codecov-commenter commented Mar 22, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.76%. Comparing base (b29bcf1) to head (191efc8).
⚠️ Report is 845 commits behind head on master.

Files with missing lines Patch % Lines
zend_abstract_interface/hook/hook.c 38.46% 8 Missing ⚠️

❌ Your patch status has failed because the patch coverage (38.46%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2591      +/-   ##
============================================
- Coverage     75.78%   75.76%   -0.02%     
  Complexity     2564     2564              
============================================
  Files           241      241              
  Lines         27055    27067      +12     
  Branches        976      976              
============================================
+ Hits          20503    20507       +4     
- Misses         6032     6040       +8     
  Partials        520      520
Flag Coverage Δ
appsec-extension 69.13% <ø> (ø)
tracer-extension 78.65% <38.46%> (-0.05%) ⬇️
tracer-php 74.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
zend_abstract_interface/hook/hook.c 54.66% <38.46%> (-0.34%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29bcf1...191efc8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter

pr-commenter Bot commented Mar 22, 2024 •
edited
Loading

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2024-03-22 16:12:41

Comparing candidate commit 191efc8 in PR branch bob/fix-internal-inherited-ctor with baseline commit b29bcf1 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 182 metrics, 0 unstable metrics.

@bwoebi
bwoebi force-pushed the bob/fix-internal-inherited-ctor branch from bfc6a76 to 191efc8 Compare March 22, 2024 15:41
iamluc
iamluc approved these changes Mar 25, 2024
View reviewed changes

@iamluc iamluc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some tests are failing.
I don't know if it's related

@bwoebi
bwoebi merged commit f9d0729 into master Mar 25, 2024
@bwoebi
bwoebi deleted the bob/fix-internal-inherited-ctor branch March 25, 2024 14:19
@github-actions github-actions Bot added this to the 0.99.0 milestone Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamluc iamluc iamluc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.99.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bwoebi @codecov-commenter @iamluc