Skip to content

ci(profiling) fix asan test#2578

Merged
realFlowControl merged 1 commit intomasterfrom
florian/fix-asan
Mar 19, 2024
Merged

ci(profiling) fix asan test#2578
realFlowControl merged 1 commit intomasterfrom
florian/fix-asan

Conversation

@realFlowControl
Copy link
Copy Markdown
Member

@realFlowControl realFlowControl commented Mar 19, 2024

Description

This should fix the ASAN test, see actions/runner-images#9491 (comment)

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@realFlowControl realFlowControl requested a review from a team as a code owner March 19, 2024 14:24
@github-actions github-actions Bot added the profiling Relates to the Continuous Profiler label Mar 19, 2024
Copy link
Copy Markdown
Contributor

@PROFeNoM PROFeNoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THANK YOU 🙇

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 19, 2024

Codecov Report

Merging #2578 (1b88c7c) into master (91227e5) will decrease coverage by 26.56%.
The diff coverage is n/a.

❗ Current head 1b88c7c differs from pull request most recent head 5f42785. Consider uploading reports for the commit 5f42785 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master    #2578       +/-   ##
=============================================
- Coverage     75.77%   49.22%   -26.56%     
  Complexity     2563     2563               
=============================================
  Files           241      215       -26     
  Lines         27024    23052     -3972     
  Branches        976        0      -976     
=============================================
- Hits          20478    11347     -9131     
- Misses         6026    11705     +5679     
+ Partials        520        0      -520     
Flag Coverage Δ
appsec-extension ?
tracer-extension 78.70% <ø> (ø)
tracer-php 12.70% <ø> (-62.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 88 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91227e5...5f42785. Read the comment docs.

@realFlowControl realFlowControl merged commit 7c36868 into master Mar 19, 2024
@realFlowControl realFlowControl deleted the florian/fix-asan branch March 19, 2024 14:50
@github-actions github-actions Bot added this to the 0.99.0 milestone Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

profiling Relates to the Continuous Profiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants