Skip to content

Send spans_created telemetry metric#2577

Merged
iamluc merged 18 commits intomasterfrom
lv/tracer-telemetry
Mar 29, 2024
Merged

Send spans_created telemetry metric#2577
iamluc merged 18 commits intomasterfrom
lv/tracer-telemetry

Conversation

@iamluc
Copy link
Copy Markdown
Contributor

@iamluc iamluc commented Mar 19, 2024

Description

spans_created is the first telemetry metric collected as part of https://datadoghq.atlassian.net/browse/AIT-4125

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@iamluc iamluc mentioned this pull request Mar 19, 2024
Merged
2 tasks
bwoebi
bwoebi reviewed Mar 22, 2024
View reviewed changes
Comment thread ext/span.h Outdated
bwoebi
bwoebi reviewed Mar 22, 2024
View reviewed changes
Comment thread ext/ddtrace.c Outdated
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 22, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-03-28 19:40:07

Comparing candidate commit c21845b in PR branch lv/tracer-telemetry with baseline commit 8e98f4d in branch master.

Found 13 performance improvements and 1 performance regressions! Performance is the same for 168 metrics, 0 unstable metrics.

scenario:EmptyFileBench/benchEmptyFileOverhead

  • 🟩 execution_time [-358.485µs; -242.955µs] or [-10.390%; -7.042%]

scenario:EmptyFileBench/benchEmptyFileOverhead-opcache

  • 🟩 execution_time [-366.606µs; -262.774µs] or [-10.264%; -7.357%]

scenario:HookBench/benchWithoutHook-opcache

  • 🟩 execution_time [-3.433µs; -2.166µs] or [-6.642%; -4.191%]

scenario:LaravelBench/benchLaravelOverhead

  • 🟩 execution_time [-339.723µs; -227.077µs] or [-9.513%; -6.358%]

scenario:LaravelBench/benchLaravelOverhead-opcache

  • 🟩 execution_time [-395.047µs; -246.493µs] or [-10.603%; -6.616%]

scenario:SpanBench/benchDatadogAPI-opcache

  • 🟥 execution_time [+409.560ns; +686.440ns] or [+2.364%; +3.961%]

scenario:SymfonyBench/benchSymfonyBaseline

  • 🟩 execution_time [-337.620µs; -294.860µs] or [-5.689%; -4.968%]

scenario:SymfonyBench/benchSymfonyBaseline-opcache

  • 🟩 execution_time [-336.061µs; -237.539µs] or [-5.543%; -3.918%]

scenario:SymfonyBench/benchSymfonyOverhead

  • 🟩 execution_time [-707.544µs; -651.096µs] or [-9.097%; -8.371%]

scenario:SymfonyBench/benchSymfonyOverhead-opcache

  • 🟩 execution_time [-722.734µs; -655.226µs] or [-9.139%; -8.286%]

scenario:WordPressBench/benchEnhancedWordPressOverhead

  • 🟩 execution_time [-6.490ms; -4.706ms] or [-3.060%; -2.219%]

scenario:WordPressBench/benchEnhancedWordPressOverhead-opcache

  • 🟩 execution_time [-7.327ms; -6.103ms] or [-3.437%; -2.863%]

scenario:WordPressBench/benchWordPressOverhead

  • 🟩 execution_time [-10.208ms; -8.083ms] or [-4.747%; -3.759%]

scenario:WordPressBench/benchWordPressOverhead-opcache

  • 🟩 execution_time [-9.867ms; -7.866ms] or [-4.574%; -3.646%]

@iamluc iamluc force-pushed the lv/tracer-telemetry branch from f391995 to a2e4165 Compare March 25, 2024 10:29
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 25, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 98.18182% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 75.52%. Comparing base (8e98f4d) to head (2a269e0).
⚠️ Report is 805 commits behind head on master.

Files with missing lines Patch % Lines
ext/telemetry.c 96.55% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2577      +/-   ##
============================================
+ Coverage     75.47%   75.52%   +0.04%     
  Complexity     2603     2603              
============================================
  Files           242      242              
  Lines         27225    27276      +51     
  Branches        985      985              
============================================
+ Hits          20549    20599      +50     
- Misses         6151     6152       +1     
  Partials        525      525
Flag Coverage Δ
appsec-extension 69.01% <ø> (ø)
tracer-extension 78.71% <97.61%> (+0.06%) ⬆️
tracer-php 74.08% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ext/ddtrace.c 73.31% <100.00%> (+0.18%) ⬆️
ext/ddtrace.h 62.50% <ø> (ø)
ext/ddtrace_arginfo.h 100.00% <100.00%> (ø)
ext/span.c 93.01% <100.00%> (+0.01%) ⬆️
ext/span.h 100.00% <ø> (ø)
src/DDTrace/OpenTelemetry/Span.php 85.71% <100.00%> (+0.07%) ⬆️
src/DDTrace/OpenTracer/Tracer.php 86.88% <100.00%> (+0.92%) ⬆️
src/DDTrace/OpenTracer1/Tracer.php 86.66% <100.00%> (+0.95%) ⬆️
ext/telemetry.c 98.82% <96.55%> (-1.18%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e98f4d...2a269e0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@iamluc iamluc force-pushed the lv/tracer-telemetry branch 5 times, most recently from ec441aa to 996cfe6 Compare March 27, 2024 19:09
@iamluc iamluc marked this pull request as ready for review March 28, 2024 12:57
@iamluc iamluc requested a review from a team as a code owner March 28, 2024 12:57
@bwoebi bwoebi changed the base branch from ddtrace-1.0.0 to master March 28, 2024 12:59
@bwoebi bwoebi requested review from a team as code owners March 28, 2024 12:59
@bwoebi bwoebi force-pushed the lv/tracer-telemetry branch 2 times, most recently from 5ed1e3c to b3de131 Compare March 28, 2024 18:25
@bwoebi
Update libdatadog, cbindgen
c21845b 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi force-pushed the lv/tracer-telemetry branch from df08fc4 to c21845b Compare March 28, 2024 19:08
bwoebi
bwoebi approved these changes Mar 28, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@iamluc iamluc merged commit 7169ff4 into master Mar 29, 2024
@iamluc iamluc deleted the lv/tracer-telemetry branch March 29, 2024 09:52
@github-actions github-actions Bot added this to the 0.99.0 milestone Mar 29, 2024
realFlowControl added a commit that referenced this pull request Apr 4, 2024
@realFlowControl
Revert "Send spans_created telemetry metric (#2577)"
dfa7f9f 
This reverts commit 7169ff4.
@realFlowControl realFlowControl mentioned this pull request Apr 4, 2024
Closed
realFlowControl added a commit that referenced this pull request Apr 4, 2024
@realFlowControl
Revert "Send spans_created telemetry metric (#2577)"
8e6c72b 
This reverts commit 7169ff4.
iamluc added a commit that referenced this pull request Apr 9, 2024
@iamluc
Reapply "Send spans_created telemetry metric (#2577)"
5e7cc99 
This reverts commit 8e6c72b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.99.0

Development

Successfully merging this pull request may close these issues.

3 participants

@iamluc @codecov-commenter @bwoebi