Skip to content

Fix fibers with tracer disabled#2576

Merged
bwoebi merged 1 commit intomasterfrom
bob/fix-fibers
Mar 20, 2024
Merged

Fix fibers with tracer disabled#2576
bwoebi merged 1 commit intomasterfrom
bob/fix-fibers

Conversation

@bwoebi
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi commented Mar 19, 2024

Description

Fibers were crashing when using ddtrace.disable=1.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@bwoebi bwoebi requested a review from a team as a code owner March 19, 2024 11:51
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 19, 2024

Benchmarks

Benchmark execution time: 2024-03-19 12:21:00

Comparing candidate commit 87effa0 in PR branch bob/fix-fibers with baseline commit 91227e5 in branch master.

Found 0 performance improvements and 3 performance regressions! Performance is the same for 179 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline

  • 🟥 execution_time [+15.779µs; +16.391µs] or [+9.108%; +9.461%]

scenario:PDOBench/benchPDOOverhead

  • 🟥 execution_time [+14.299µs; +16.086µs] or [+5.310%; +5.974%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟥 execution_time [+15.079µs; +17.317µs] or [+5.178%; +5.946%]

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 19, 2024 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.77%. Comparing base (91227e5) to head (87effa0).
⚠️ Report is 970 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2576   +/-   ##
=========================================
  Coverage     75.77%   75.77%           
  Complexity     2563     2563           
=========================================
  Files           241      241           
  Lines         27024    27024           
  Branches        976      976           
=========================================
  Hits          20478    20478           
  Misses         6026     6026           
  Partials        520      520
Flag Coverage Δ
appsec-extension 69.13% <ø> (ø)
tracer-extension 78.70% <100.00%> (ø)
tracer-php 74.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ext/ddtrace.c 73.13% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91227e5...87effa0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bwoebi bwoebi merged commit 5e73d78 into master Mar 20, 2024
@bwoebi bwoebi deleted the bob/fix-fibers branch March 20, 2024 13:27
@github-actions github-actions Bot added this to the 0.99.0 milestone Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iamluc iamluc iamluc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.99.0

Development

Successfully merging this pull request may close these issues.

3 participants

@bwoebi @codecov-commenter @iamluc