Skip to content

Enable appsec by ini only when enable-appsec present#2567

Merged
estringana merged 1 commit intomasterfrom
estringana/fix-appsec-setup
Mar 14, 2024
Merged

Enable appsec by ini only when enable-appsec present#2567
estringana merged 1 commit intomasterfrom
estringana/fix-appsec-setup

Conversation

@estringana
Copy link
Copy Markdown
Contributor

@estringana estringana commented Mar 12, 2024

Description

Amend bug which was setting datadog.appsec.enabled either On or Off on the .ini file.

When enable-appsec flag is not present , datadog.appsec.enabled should be commented out on the .ini file. This way, remote config will be able to enable appsec.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@estringana estringana marked this pull request as ready for review March 12, 2024 14:04
@estringana estringana requested a review from a team as a code owner March 12, 2024 14:04
Copy link
Copy Markdown
Contributor

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@estringana estringana requested a review from a team March 13, 2024 16:48
@estringana estringana merged commit 7eb4638 into master Mar 14, 2024
@estringana estringana deleted the estringana/fix-appsec-setup branch March 14, 2024 08:40
@github-actions github-actions Bot added this to the 0.99.0 milestone Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants