Update to use DDOG_CHARSLICE_C and new DDOG_CHARSLICE_C_BARE helpers#2565
Update to use DDOG_CHARSLICE_C and new DDOG_CHARSLICE_C_BARE helpers#2565
DDOG_CHARSLICE_C and new DDOG_CHARSLICE_C_BARE helpers#2565Conversation
**What does this PR do?** This PR updated dd-trace-php to use the helpers that were changed/ introduced in DataDog/libdatadog#347 . TL;DR: `DDOG_CHARSLICE_C` includes the cast to `(ddog_CharSlice)` to all uses of `(ddog_CharSlice) DDOG_CHARSLICE_C` in the codebase were converted to not have the cast; and `DDOG_CHARSLICE_C_BARE` does not have the cast, so all uses of `DDOG_CHARSLICE_C` without the cast in the codebase were converted to this one. **Motivation:** Update to match the latest libdatadog changes. **Additional Notes:** This is my first dd-trace-php contribution I think? **How to test the change?** I'm guessing CI should be able to validate this (?), not very familiar with our testing setup.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2565 +/- ##
============================================
- Coverage 77.07% 75.91% -1.17%
Complexity 2563 2563
============================================
Files 215 241 +26
Lines 23048 27020 +3972
Branches 0 976 +976
============================================
+ Hits 17765 20511 +2746
- Misses 5283 5989 +706
- Partials 0 520 +520
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2024-03-11 15:54:15 Comparing candidate commit ac0a7cc in PR branch Found 2 performance improvements and 0 performance regressions! Performance is the same for 180 metrics, 0 unstable metrics. scenario:PDOBench/benchPDOBaseline-opcache
scenario:PDOBench/benchPDOOverheadWithDBM-opcache
|
bwoebi
left a comment
bwoebi
left a comment
There was a problem hiding this comment.
Thanks, just updated libdatadog so that the cbindgen check doesn't fail :-)
3 participants
Description
What does this PR do?
This PR updated dd-trace-php to use the helpers that were changed/ introduced in DataDog/libdatadog#347 .
TL;DR:
DDOG_CHARSLICE_Cincludes the cast to(ddog_CharSlice)to all uses of(ddog_CharSlice) DDOG_CHARSLICE_Cin the codebase were converted to not have the cast; andDDOG_CHARSLICE_C_BAREdoes not have the cast, so all uses ofDDOG_CHARSLICE_Cwithout the cast in the codebase were converted to this one.Motivation:
Update to match the latest libdatadog changes.
Additional Notes:
This is my first dd-trace-php contribution I think?
How to test the change?
I'm guessing CI should be able to validate this (?), not very familiar with our testing setup.
Reviewer checklist