ci(profiling) add tests for exception profiling in ZTS builds#2562
ci(profiling) add tests for exception profiling in ZTS builds#2562realFlowControl merged 6 commits intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2562 +/- ##
============================================
+ Coverage 75.91% 77.08% +1.16%
Complexity 2574 2574
============================================
Files 240 214 -26
Lines 27029 23057 -3972
Branches 976 0 -976
============================================
- Hits 20519 17773 -2746
+ Misses 5990 5284 -706
+ Partials 520 0 -520
Flags with carried forward coverage won't be shown. Click here to find out more. see 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
realFlowControl
force-pushed
the
florian/exception-zts
branch
13 times, most recently
from
69c50a0 to
700b423
Compare
realFlowControl
force-pushed
the
florian/exception-zts
branch
3 times, most recently
from
c37d094 to
cc5f0cf
Compare
realFlowControl
force-pushed
the
florian/exception-zts
branch
from
ad02aa2 to
0cd4264
Compare
| let exception_profiling = REQUEST_LOCALS.with(|cell| { | ||
| cell.try_borrow() | ||
| .map(|locals| locals.system_settings().profiling_exception_enabled) | ||
| .unwrap_or(false) | ||
| }); | ||
|
|
||
| if !exception_profiling { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
As of recently the INI is a true INI_SYSTEM, which means it can not be changed anymore (not per user dir or any other fancy things), which is also intended behaviour. With this change, we also do not show the "Exception profiling initialized .." message anymore in case it is disabled
3 participants
Description
This PR will add some tests for exception profiling in ZTS PHP builds:
ext-parallelPROF-8923 / #2070
Reviewer checklist