Skip to content

Slightly Improve OTel Performances#2561

Merged
PROFeNoM merged 4 commits intomasterfrom
alex/perf/otel-bis
Mar 29, 2024
Merged

Slightly Improve OTel Performances#2561
PROFeNoM merged 4 commits intomasterfrom
alex/perf/otel-bis

Conversation

@PROFeNoM
Copy link
Copy Markdown
Contributor

@PROFeNoM PROFeNoM commented Mar 8, 2024 •
edited
Loading

Description

  • Don't build an attributes builder instance since we don't apply attributes limit anyway
  • Don't build a new tracestate instance if the tracestate didn't change
  • More efficient condition checks

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM force-pushed the alex/perf/otel-bis branch from 8b53642 to c52aece Compare March 22, 2024 13:11
@PROFeNoM PROFeNoM self-assigned this Mar 22, 2024
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 22, 2024

Benchmarks

Benchmark execution time: 2024-03-22 13:42:16

Comparing candidate commit c52aece in PR branch alex/perf/otel-bis with baseline commit b29bcf1 in branch master.

Found 5 performance improvements and 3 performance regressions! Performance is the same for 174 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOBaseline-opcache

  • 🟥 execution_time [+16.859µs; +18.613µs] or [+9.826%; +10.848%]

scenario:PDOBench/benchPDOOverhead-opcache

  • 🟥 execution_time [+16.471µs; +18.205µs] or [+5.928%; +6.553%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

  • 🟥 execution_time [+16.638µs; +18.669µs] or [+5.501%; +6.172%]

scenario:SamplingRuleMatchingBench/benchRegexMatching3-opcache

  • 🟩 execution_time [-349.738ns; -134.062ns] or [-5.605%; -2.148%]

scenario:SpanBench/benchOpenTelemetryAPI

  • 🟩 execution_time [-32.854µs; -28.905µs] or [-10.192%; -8.967%]

scenario:SpanBench/benchOpenTelemetryAPI-opcache

  • 🟩 execution_time [-24.322µs; -17.972µs] or [-8.989%; -6.643%]

scenario:SpanBench/benchOpenTelemetryInteroperability

  • 🟩 execution_time [-31.490µs; -17.811µs] or [-3.642%; -2.060%]

scenario:SpanBench/benchOpenTelemetryInteroperability-opcache

  • 🟩 execution_time [-35.232µs; -16.413µs] or [-4.813%; -2.242%]

@PROFeNoM PROFeNoM changed the title Improve OTel Performances Slightly Improve OTel Performances Mar 22, 2024
@PROFeNoM PROFeNoM marked this pull request as ready for review March 22, 2024 14:07
@PROFeNoM PROFeNoM requested a review from a team as a code owner March 22, 2024 14:07
bwoebi
bwoebi approved these changes Mar 22, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peeeerformance :-) More! :-)

@bwoebi
Copy link
Copy Markdown
Collaborator

bwoebi commented Mar 22, 2024

Hm, the Otel parametric tests fail.

@PROFeNoM
Copy link
Copy Markdown
Contributor Author

PROFeNoM commented Mar 22, 2024

Will fix it on monday

@PROFeNoM PROFeNoM mentioned this pull request Mar 27, 2024
Merged
9 tasks
@PROFeNoM
Copy link
Copy Markdown
Contributor Author

PROFeNoM commented Mar 27, 2024

Made a PR to the system-tests repo to address the parametric test failure

@PROFeNoM PROFeNoM merged commit 0ca98e6 into master Mar 29, 2024
@PROFeNoM PROFeNoM deleted the alex/perf/otel-bis branch March 29, 2024 08:37
@github-actions github-actions Bot added this to the 0.99.0 milestone Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebi bwoebi bwoebi approved these changes

Assignees

@PROFeNoM PROFeNoM

Labels

cat:opentelemetry cat:performance

Projects

None yet

Milestone

0.99.0

Development

Successfully merging this pull request may close these issues.

2 participants

@PROFeNoM @bwoebi