Handle relative ext/ paths and test the windows installer#2559
Merged
Handle relative ext/ paths and test the windows installer#2559
Conversation
Signed-off-by: Bob Weinand <[email protected]>
bwoebi
force-pushed
the
bob/relative-ext-path
branch
from
286d343 to
17bbafb
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2559 +/- ##
=========================================
Coverage 75.91% 75.91%
Complexity 2574 2574
=========================================
Files 240 240
Lines 27029 27029
Branches 976 976
=========================================
Hits 20519 20519
Misses 5990 5990
Partials 520 520
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
PROFeNoM
approved these changes
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes src/ dir copy and avoids the
.dllsuffix at all costs for windows.Reviewer checklist