Skip to content

test: Don't check for mysqli spans in WordPress tests#2556

Merged
PROFeNoM merged 1 commit intomasterfrom
alex/test/wp-only
Mar 5, 2024
Merged

test: Don't check for mysqli spans in WordPress tests#2556
PROFeNoM merged 1 commit intomasterfrom
alex/test/wp-only

Conversation

@PROFeNoM
Copy link
Copy Markdown
Contributor

@PROFeNoM PROFeNoM commented Mar 5, 2024

Description

Needed for #2550

Additionally, there were two additional mysqli_query spans in one test from this PR. Let's just test what we want actually to test.

With this PR, mysqli spans are stripped-off from WordPress snapshots. They will be easier to maintain, read, and that's anyway what we do for other suites.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@PROFeNoM PROFeNoM self-assigned this Mar 5, 2024
@PROFeNoM PROFeNoM mentioned this pull request Mar 5, 2024
2 tasks
@PROFeNoM PROFeNoM marked this pull request as ready for review March 5, 2024 12:27
@PROFeNoM PROFeNoM requested a review from a team as a code owner March 5, 2024 12:27
@PROFeNoM
Copy link
Copy Markdown
Contributor Author

PROFeNoM commented Mar 5, 2024

The check snapshots failure is a non-issue

Body is too long (maximum is 65536 characters)

@PROFeNoM PROFeNoM merged commit dc24c31 into master Mar 5, 2024
@PROFeNoM PROFeNoM deleted the alex/test/wp-only branch March 5, 2024 13:50
@github-actions github-actions Bot added this to the 0.99.0 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants