Skip to content

Speed composer dependency parsing up#2551

Merged
bwoebi merged 3 commits intomasterfrom
bob/fast-dep-parse
Mar 5, 2024
Merged

Speed composer dependency parsing up#2551
bwoebi merged 3 commits intomasterfrom
bob/fast-dep-parse

Conversation

@bwoebi
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi commented Mar 1, 2024

Description

Speeeed? Speeeed!


Moving dependency parsing to the sidecar including caching there.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 1, 2024

Benchmarks

Benchmark execution time: 2024-03-05 17:44:00

Comparing candidate commit 87de3e4 in PR branch bob/fast-dep-parse with baseline commit 0a86e15 in branch master.

Found 14 performance improvements and 3 performance regressions! Performance is the same for 165 metrics, 0 unstable metrics.

scenario:ComposerTelemetryBench/benchTelemetryParsing

  • 🟩 execution_time [-3.843ms; -3.828ms] or [-98.737%; -98.359%]

scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache

  • 🟩 execution_time [-3.852ms; -3.835ms] or [-98.766%; -98.331%]

scenario:EmptyFileBench/benchEmptyFileOverhead

  • 🟩 execution_time [-403.797µs; -285.463µs] or [-11.691%; -8.265%]

scenario:EmptyFileBench/benchEmptyFileOverhead-opcache

  • 🟩 execution_time [-348.479µs; -238.541µs] or [-9.761%; -6.682%]

scenario:LaravelBench/benchLaravelOverhead

  • 🟩 execution_time [-394.672µs; -299.228µs] or [-10.924%; -8.282%]

scenario:LaravelBench/benchLaravelOverhead-opcache

  • 🟩 execution_time [-348.093µs; -231.007µs] or [-9.431%; -6.259%]

scenario:PDOBench/benchPDOBaseline

  • 🟥 execution_time [+16.329µs; +17.486µs] or [+9.481%; +10.152%]

scenario:PDOBench/benchPDOOverhead

  • 🟥 execution_time [+16.621µs; +17.797µs] or [+6.237%; +6.679%]

scenario:PDOBench/benchPDOOverheadWithDBM

  • 🟥 execution_time [+16.821µs; +18.952µs] or [+5.829%; +6.567%]

scenario:SymfonyBench/benchSymfonyBaseline

  • 🟩 execution_time [-340.794µs; -242.526µs] or [-5.731%; -4.079%]

scenario:SymfonyBench/benchSymfonyBaseline-opcache

  • 🟩 execution_time [-292.713µs; -183.047µs] or [-4.810%; -3.008%]

scenario:SymfonyBench/benchSymfonyOverhead

  • 🟩 execution_time [-728.888µs; -679.432µs] or [-9.392%; -8.755%]

scenario:SymfonyBench/benchSymfonyOverhead-opcache

  • 🟩 execution_time [-652.532µs; -504.428µs] or [-8.259%; -6.384%]

scenario:TraceSerializationBench/benchSerializeTrace

  • 🟩 execution_time [-7.389µs; -4.511µs] or [-4.043%; -2.468%]

scenario:WordPressBench/benchEnhancedWordPressOverhead-opcache

  • 🟩 execution_time [-8.416ms; -5.476ms] or [-3.970%; -2.583%]

scenario:WordPressBench/benchWordPressOverhead

  • 🟩 execution_time [-9.791ms; -7.369ms] or [-4.572%; -3.441%]

scenario:WordPressBench/benchWordPressOverhead-opcache

  • 🟩 execution_time [-9.103ms; -6.997ms] or [-4.262%; -3.276%]

@bwoebi bwoebi force-pushed the bob/fast-dep-parse branch 2 times, most recently from 852ab7d to c88afbc Compare March 2, 2024 00:17
@bwoebi bwoebi force-pushed the bob/fast-dep-parse branch from c88afbc to 8353066 Compare March 4, 2024 18:07
@bwoebi bwoebi marked this pull request as ready for review March 4, 2024 19:02
@bwoebi bwoebi requested review from a team as code owners March 4, 2024 19:02
Copy link
Copy Markdown
Contributor

@PROFeNoM PROFeNoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speed 🚤

@bwoebi bwoebi force-pushed the bob/fast-dep-parse branch from 7d5b31a to d7b2b48 Compare March 5, 2024 14:45
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 5, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.91%. Comparing base (0a86e15) to head (87de3e4).
⚠️ Report is 1307 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2551      +/-   ##
============================================
- Coverage     77.08%   75.91%   -1.17%     
  Complexity     2574     2574              
============================================
  Files           214      240      +26     
  Lines         23057    27029    +3972     
  Branches          0      976     +976     
============================================
+ Hits          17773    20519    +2746     
- Misses         5284     5990     +706     
- Partials          0      520     +520     
Flag Coverage Δ
appsec-extension 69.13% <ø> (?)
tracer-extension 78.70% <100.00%> (ø)
tracer-php 75.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ext/telemetry.c 100.00% <100.00%> (ø)

... and 26 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a86e15...87de3e4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bwoebi bwoebi force-pushed the bob/fast-dep-parse branch from d7b2b48 to ca89b28 Compare March 5, 2024 16:07
@bwoebi bwoebi force-pushed the bob/fast-dep-parse branch from ca89b28 to 87de3e4 Compare March 5, 2024 17:12
@bwoebi bwoebi merged commit 2e1ed12 into master Mar 5, 2024
@bwoebi bwoebi deleted the bob/fast-dep-parse branch March 5, 2024 18:28
@github-actions github-actions Bot added this to the 0.99.0 milestone Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants