Conversation
bwoebi
force-pushed
the
bob/ipc-bincode
branch
2 times, most recently
from
708207e to
353aedb
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2544 +/- ##
============================================
+ Coverage 76.55% 78.73% +2.18%
Complexity 267 267
============================================
Files 138 112 -26
Lines 17457 13485 -3972
Branches 976 0 -976
============================================
- Hits 13364 10618 -2746
+ Misses 3573 2867 -706
+ Partials 520 0 -520
Flags with carried forward coverage won't be shown. Click here to find out more. see 26 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
bwoebi
force-pushed
the
bob/ipc-bincode
branch
from
353aedb to
a8d40e8
Compare
BenchmarksBenchmark execution time: 2024-03-04 10:26:47 Comparing candidate commit 4486d06 in PR branch Found 9 performance improvements and 6 performance regressions! Performance is the same for 163 metrics, 4 unstable metrics. scenario:ComposerTelemetryBench/benchTelemetryParsing
scenario:ComposerTelemetryBench/benchTelemetryParsing-opcache
scenario:ContextPropagationBench/benchInject64Bit
scenario:EmptyFileBench/benchEmptyFileBaseline
scenario:EmptyFileBench/benchEmptyFileBaseline-opcache
scenario:EmptyFileBench/benchEmptyFileOverhead
scenario:EmptyFileBench/benchEmptyFileOverhead-opcache
scenario:LaravelBench/benchLaravelBaseline
scenario:LaravelBench/benchLaravelBaseline-opcache
scenario:LaravelBench/benchLaravelOverhead
scenario:LaravelBench/benchLaravelOverhead-opcache
scenario:SymfonyBench/benchSymfonyBaseline
scenario:SymfonyBench/benchSymfonyBaseline-opcache
scenario:SymfonyBench/benchSymfonyOverhead
scenario:SymfonyBench/benchSymfonyOverhead-opcache
|
Signed-off-by: Bob Weinand <[email protected]>
PROFeNoM
approved these changes
Mar 4, 2024
Contributor
PROFeNoM
left a comment
PROFeNoM
left a comment
There was a problem hiding this comment.
Running the macrobenchmarks, there doesn't seem to be any macro impact on real-world web apps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Should bring a considerable speedup by not using json, which is comparatively slower.
Reviewer checklist