Get rid of some bitwise checking in ddog_shall_log#2539
Merged
Conversation
Signed-off-by: Bob Weinand <[email protected]>
bwoebi
force-pushed
the
bob/micro-optimize-shall_log
branch
from
c77d8a1 to
8b3ba1b
Compare
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (37.41%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #2539 +/- ##
============================================
- Coverage 78.30% 76.54% -1.76%
Complexity 267 267
============================================
Files 112 138 +26
Lines 13458 17459 +4001
Branches 0 976 +976
============================================
+ Hits 10538 13364 +2826
- Misses 2920 3575 +655
- Partials 0 520 +520
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 34 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
BenchmarksBenchmark execution time: 2024-02-27 15:57:05 Comparing candidate commit b436003 in PR branch Found 14 performance improvements and 1 performance regressions! Performance is the same for 167 metrics, 0 unstable metrics. scenario:HookBench/benchHookOverheadInstallHookOnFunction
scenario:HookBench/benchHookOverheadInstallHookOnFunction-opcache
scenario:HookBench/benchHookOverheadInstallHookOnMethod
scenario:HookBench/benchHookOverheadInstallHookOnMethod-opcache
scenario:LogsInjectionBench/benchLogsInfoInjection
scenario:MessagePackSerializationBench/benchMessagePackSerialization
scenario:PDOBench/benchPDOBaseline-opcache
scenario:PDOBench/benchPDOOverhead-opcache
scenario:PDOBench/benchPDOOverheadWithDBM-opcache
scenario:SpanBench/benchDatadogAPI
scenario:SpanBench/benchDatadogAPI-opcache
scenario:SpanBench/benchOpenTelemetryAPI
scenario:TraceAnnotationsBench/benchTraceAnnotationOverhead-opcache
scenario:TraceSerializationBench/benchSerializeTrace
scenario:TraceSerializationBench/benchSerializeTrace-opcache
|
PROFeNoM
previously approved these changes
Feb 27, 2024
PROFeNoM
dismissed
their stale review
Hum, there seems to be an issue compiling ddtelemetry (Rust).
bwoebi
force-pushed
the
bob/micro-optimize-shall_log
branch
2 times, most recently
from
bd4e1ec to
c533eb6
Compare
bwoebi
force-pushed
the
bob/micro-optimize-shall_log
branch
from
c533eb6 to
b436003
Compare
PROFeNoM
approved these changes
Feb 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Micro-optimization for logging
Reviewer checklist