feat(profiling) report PHP build (NTS vs ZTS)#2536
Merged
realFlowControl merged 1 commit intomasterfrom Mar 8, 2024
Merged
Conversation
bwoebi
approved these changes
Feb 23, 2024
Collaborator
bwoebi
left a comment
bwoebi
left a comment
There was a problem hiding this comment.
Looks sensible to me :-)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2536 +/- ##
============================================
+ Coverage 75.91% 77.08% +1.16%
Complexity 2574 2574
============================================
Files 240 214 -26
Lines 27029 23057 -3972
Branches 976 0 -976
============================================
- Hits 20519 17773 -2746
+ Misses 5990 5284 -706
+ Partials 520 0 -520
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
realFlowControl
force-pushed
the
florian/tag-zts
branch
from
5bdf2b2 to
901496c
Compare
morrisonlevi
approved these changes
Mar 8, 2024
realFlowControl
changed the title
NTS vs ZTS)NTS vs ZTS)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PROF-9204 / #2070
This PR will add the PHP build (
ZTSvsNTS) as a tag (runtime_engine) to the profiles. In more detail: we will start reporting ZTS aszend-zts-ndebugand NTS aszend-nts-ndebug(because there is nodebugbuild support so far). In case we would supportdebugbuilds, we'd also add azend-nts-debugandzend-zts-debugvalue.Reviewer checklist