Skip to content

Add DD_API_SECURITY_ENABLED flag#2532

Merged
estringana merged 3 commits intomasterfrom
estringana/add-api-security-enabled
Feb 27, 2024
Merged

Add DD_API_SECURITY_ENABLED flag#2532
estringana merged 3 commits intomasterfrom
estringana/add-api-security-enabled

Conversation

@estringana
Copy link
Copy Markdown
Contributor

@estringana estringana commented Feb 22, 2024

Description

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@estringana estringana force-pushed the estringana/add-api-security-enabled branch from 4a7d2d3 to 1e69c13 Compare February 22, 2024 14:35
@estringana estringana marked this pull request as ready for review February 22, 2024 16:54
@estringana estringana requested a review from a team as a code owner February 22, 2024 16:54
bwoebi
bwoebi reviewed Feb 23, 2024
View reviewed changes
Comment thread appsec/src/extension/configuration.h Outdated
Anilm3
Anilm3 requested changes Feb 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sample rate should not be removed, the new variable should be present in addition to the sample rate.

@estringana
Copy link
Copy Markdown
Contributor Author

estringana commented Feb 27, 2024

The sample rate should not be removed, the new variable should be present in addition to the sample rate.

Done

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 27, 2024 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.56%. Comparing base (b25dc1e) to head (6a7683f).
⚠️ Report is 869 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2532      +/-   ##
============================================
- Coverage     78.75%   76.56%   -2.19%     
  Complexity      267      267              
============================================
  Files           112      138      +26     
  Lines         13482    17454    +3972     
  Branches          0      976     +976     
============================================
+ Hits          10618    13364    +2746     
- Misses         2864     3570     +706     
- Partials          0      520     +520
Flag Coverage Δ
appsec-extension 69.13% <100.00%> (?)
tracer-extension 78.71% <ø> (ø)
tracer-integrations 79.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
appsec/src/extension/commands/client_init.c 84.21% <100.00%> (ø)
appsec/src/extension/configuration.h 100.00% <ø> (ø)

... and 24 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25dc1e...6a7683f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@estringana estringana requested a review from Anilm3 February 27, 2024 11:33
Anilm3
Anilm3 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@Anilm3 Anilm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@estringana estringana merged commit 48ba7d7 into master Feb 27, 2024
@estringana estringana deleted the estringana/add-api-security-enabled branch February 27, 2024 14:11
@github-actions github-actions Bot added this to the 0.99.0 milestone Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bwoebi bwoebi bwoebi left review comments

@Anilm3 Anilm3 Anilm3 approved these changes

@cataphract cataphract Awaiting requested review from cataphract

+1 more reviewer

@bateller bateller bateller approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:asm tracing

Projects

None yet

Milestone

0.99.0

Development

Successfully merging this pull request may close these issues.

5 participants

@estringana @codecov-commenter @Anilm3 @bwoebi @bateller