Skip to content

Ensure the permissions of the log file are actually really 0666#2528

Merged
bwoebi merged 1 commit intomasterfrom
bob/umask-log-file
Feb 22, 2024
Merged

Ensure the permissions of the log file are actually really 0666#2528
bwoebi merged 1 commit intomasterfrom
bob/umask-log-file

Conversation

@bwoebi
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi commented Feb 21, 2024

Description

We should probably ensure the sidecar doesn't fail spawning if the permissions of the log file don't match.

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@bwoebi bwoebi force-pushed the bob/umask-log-file branch from a1b0f99 to 45e0e95 Compare February 22, 2024 12:01
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 22, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.55%. Comparing base (b25dc1e) to head (a034ff8).
⚠️ Report is 907 commits behind head on master.

Files with missing lines Patch % Lines
ext/logging.c 33.33% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2528      +/-   ##
============================================
- Coverage     78.75%   76.55%   -2.21%     
  Complexity      267      267              
============================================
  Files           112      138      +26     
  Lines         13482    17459    +3977     
  Branches          0      976     +976     
============================================
+ Hits          10618    13365    +2747     
- Misses         2864     3574     +710     
- Partials          0      520     +520
Flag Coverage Δ
appsec-extension 69.09% <ø> (?)
tracer-extension 78.70% <33.33%> (-0.02%) ⬇️
tracer-integrations 79.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ext/logging.c 72.72% <33.33%> (-1.11%) ⬇️

... and 26 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b25dc1e...a034ff8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Feb 22, 2024 •
edited
Loading

Benchmarks

Benchmark execution time: 2024-02-22 15:26:24

Comparing candidate commit a034ff8 in PR branch bob/umask-log-file with baseline commit b25dc1e in branch master.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 180 metrics, 0 unstable metrics.

scenario:PDOBench/benchPDOOverhead-opcache

  • 🟥 execution_time [+14.408µs; +15.902µs] or [+5.011%; +5.531%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

  • 🟥 execution_time [+14.528µs; +16.972µs] or [+4.595%; +5.368%]

@bwoebi bwoebi force-pushed the bob/umask-log-file branch from 45e0e95 to a034ff8 Compare February 22, 2024 14:01
@bwoebi bwoebi marked this pull request as ready for review February 22, 2024 14:01
@bwoebi bwoebi requested a review from a team as a code owner February 22, 2024 14:01
PROFeNoM
PROFeNoM approved these changes Feb 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@PROFeNoM PROFeNoM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AGTM! Let's just note that this test segfaults, but I'd surprised if this came with this PR.

@bwoebi bwoebi merged commit ab2dd7d into master Feb 22, 2024
@bwoebi bwoebi deleted the bob/umask-log-file branch February 22, 2024 15:51
@github-actions github-actions Bot added this to the 0.99.0 milestone Feb 22, 2024
bwoebi added a commit that referenced this pull request Mar 4, 2024
@bwoebi
Ensure the permissions of the log file are actually really 0666 (#2528)
331def6 
Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi modified the milestones: 0.99.0, 0.98.1 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PROFeNoM PROFeNoM PROFeNoM approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.98.1

Development

Successfully merging this pull request may close these issues.

3 participants

@bwoebi @codecov-commenter @PROFeNoM