Benchmarks

Benchmark execution time: 2024-03-28 10:19:27

Comparing candidate commit 6c0628b in PR branch estringana/request-params with baseline commit 76e98df in branch master.

Found 3 performance improvements and 3 performance regressions! Performance is the same for 176 metrics, 0 unstable metrics.

scenario:ContextPropagationBench/benchExtractHeaders64Bit-opcache

• 🟩 execution_time [-644.843ns; -531.157ns] or [-19.186%; -15.804%]

scenario:ContextPropagationBench/benchExtractTraceContext128Bit-opcache

• 🟥 execution_time [+491.765ns; +662.235ns] or [+11.176%; +15.051%]

scenario:ContextPropagationBench/benchExtractTraceContext64Bit-opcache

• 🟩 execution_time [-680.891ns; -595.109ns] or [-26.902%; -23.513%]

scenario:LogsInjectionBench/benchLogsInfoBaseline-opcache

• 🟥 execution_time [+482.777ns; +524.023ns] or [+15.285%; +16.590%]

scenario:PDOBench/benchPDOOverheadWithDBM-opcache

• 🟥 mem_peak [+99.696KB; +99.696KB] or [+4.423%; +4.423%]

scenario:TraceSerializationBench/benchSerializeTrace

• 🟩 execution_time [-13.719µs; -9.281µs] or [-3.978%; -2.691%]

There should also be appsec integration tests .

Just did a quick pass over the extension code and left a few comments.

On the other hand, note that request_init already sends an inferred path_params. Do you have any thoughts on how we could avoid sending those unnecessary path_params ?

Right now there is nothing implemented that makes this easy. The options are:

• Implement a new feature on the tracer that once a integration is used, maps the request targeted script to a framework. From that moment any request to that script we know it's a specific framework and then avoid sending generic parameters. This approach makes that the first request a target script will either send only the generic params or boths.
• Send generic params at rshutdown if no framework has sent them

Just did a quick pass over the extension code and left a few comments.
On the other hand, note that request_init already sends an inferred path_params. Do you have any thoughts on how we could avoid sending those unnecessary path_params ?

Right now there is nothing implemented that makes this easy. The options are:

• Implement a new feature on the tracer that once a integration is used, maps the request targeted script to a framework. From that moment any request to that script we know it's a specific framework and then avoid sending generic parameters. This approach makes that the first request a target script will either send only the generic params or boths.
• Send generic params at rshutdown if no framework has sent them

RSHUTDOWN is already too late for blocking on path_params, perhaps the first approach could work but it's a relatively large effort so perhaps it would make sense to do that in the future.

Codecov Report

❌ Patch coverage is 71.11111% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 75.78%. Comparing base (76e98df) to head (6c0628b).
⚠️ Report is 828 commits behind head on master.

❌ Your patch status has failed because the patch coverage (71.11%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

@@             Coverage Diff              @@
##             master    #2395      +/-   ##
============================================
- Coverage     76.90%   75.78%   -1.12%     
- Complexity     2564     2577      +13     
============================================
  Files           215      241      +26     
  Lines         23095    27112    +4017     
  Branches          0      985     +985     
============================================
+ Hits          17761    20548    +2787     
- Misses         5334     6039     +705     
- Partials          0      525     +525