fix(profiler) do not emit profiles when profiler is disabled#2393
Merged
Conversation
realFlowControl
marked this pull request as draft
November 28, 2023 10:04
realFlowControl
marked this pull request as ready for review
November 28, 2023 10:14
BenchmarksBenchmark execution time: 2023-11-28 11:02:57 Comparing candidate commit d65a71b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 3 unstable metrics. |
realFlowControl
force-pushed
the
florian/fix-timeline-emitting-profiles
branch
from
November 28, 2023 10:15
68c3dc1 to
87d9d12
Compare
realFlowControl
force-pushed
the
florian/fix-timeline-emitting-profiles
branch
from
November 28, 2023 10:55
87d9d12 to
d65a71b
Compare
pierotibou
approved these changes
Nov 28, 2023
morrisonlevi
approved these changes
Nov 28, 2023
realFlowControl
added a commit
that referenced
this pull request
Nov 28, 2023
* add test to ensure the profiler does not emit profiles when inactive * do not emit profiles if the feature is inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A customer contacted us that with upgrading to
0.94.0they see profiles being send to Datadog, although the profiler is disabled for them and therefore should not send profiles.The bug is that the new idle phases added in #2343 were not checking if the timeline is enabled.
This PR will add this missing check, as well as a test to ensure that in all prof-correctness cases the profiler does not emit pprof files when profiling is disabled.
SCP-378
Readiness checklist
Reviewer checklist