feat(profiling) add phases of inactivity to timeline#2315
Closed
realFlowControl wants to merge 12 commits into
Closed
feat(profiling) add phases of inactivity to timeline#2315realFlowControl wants to merge 12 commits into
realFlowControl wants to merge 12 commits into
Conversation
Collaborator
|
First thought on the gap: I would probably move the rshutdown to prshutdown. |
realFlowControl
force-pushed
the
florian/add-idle-phase-to-timeline
branch
from
October 18, 2023 07:11
376f41e to
6fa9d8d
Compare
BenchmarksBenchmark execution time: 2023-10-27 15:36:24 Comparing candidate commit 6741590 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 18 metrics, 3 unstable metrics. |
realFlowControl
marked this pull request as ready for review
October 19, 2023 07:49
realFlowControl
force-pushed
the
florian/add-idle-phase-to-timeline
branch
2 times, most recently
from
October 23, 2023 20:20
0b7bc0e to
6c46403
Compare
realFlowControl
force-pushed
the
florian/add-idle-phase-to-timeline
branch
2 times, most recently
from
October 24, 2023 10:12
595d56f to
1f2b841
Compare
realFlowControl
changed the title
realFlowControl
force-pushed
the
florian/add-idle-phase-to-timeline
branch
from
October 27, 2023 08:17
12febfe to
76babf8
Compare
Collaborator
|
We are thinking about splitting this into 2 prs. One adds the inactivity between requests and maybe the sleeps, and then everything else goes into a new PR where we think a bit more critically about what we're really trying to accomplish for those. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will add reporting of inactivity phases in PHP to the timeline:
sleep()/usleep()in userlandstream_select(),uv_run(),event_base_loop(),\EventBase\loop()and\EvLoop\run()like you'd do in the ReactPHP or Revolt event loop implementations (AMPHP uses Revolt as its event loop)php-fpm, Apachemod_phpor the PHP build-in webserver (php -S)A thing that is currently open in this PR is this problem:
As you can see at the end of the "Main" thread lane, there should also be a grey box indicating and idle phase between requests. Now this box shows up in the next pprof with the idle time being correct. When looking into real world data, this is less of a problem and we might just ignore this for now, especially as the UI handles this pretty well.
PROF-8370
Readiness checklist
Reviewer checklist