Conversation
palazzem
suggested changes
Feb 7, 2018
Contributor
palazzem
left a comment
There was a problem hiding this comment.
I would say to drop the Service API (that sends service metadata) since it's not needed. Other than that it's a good start. Thank you very much!
| */ | ||
| public function setMeta($key, $value) | ||
| { | ||
| if ($this->isFinished()) { |
| $this->traces[$span->getTraceId()][] = $span; | ||
| } | ||
|
|
||
| private function flushServices() |
Contributor
There was a problem hiding this comment.
You can remove the service API. Actually we rely in the span.type to define what kind of service this span belong (so it's a database span or a web span?). This has been introduced recently with the latest version of the Agent (5.21.1+). Some Tracers still have it (Python, Ruby and Go) just for backward compatibility. New Tracers don't need to use this endpoint.
Contributor
Author
There was a problem hiding this comment.
Great feedback. I will remove it and merge this PR.
bwoebi
pushed a commit
that referenced
this pull request
Sep 15, 2023
Thread Pool - Reuse idle threads
iamluc
added a commit
that referenced
this pull request
May 27, 2024
Direct leak of 24 byte(s) in 1 object(s) allocated from:
#0 0xffff8dfed43b in malloc (/usr/lib/aarch64-linux-gnu/libasan.so.5+0xcf43b)
#1 0xffff81eb8f4f in __cxa_thread_atexit_impl /home/circleci/datadog/tmp/build_extension/ext/ddtrace.c:560
#2 0xffff82ed7c8b in std::sys::unix::thread_local_dtor::register_dtor::ha7abe21b2e8f0491 library/std/src/sys/unix/thread_local_dtor.rs:31
#3 0xffff81ec332b in _dd_writer_loop /home/circleci/datadog/tmp/build_extension/ext/coms.c:1053
#4 0xffff8db7a7e3 in start_thread /build/glibc-tVuo8E/glibc-2.28/nptl/pthread_create.c:486
#5 0xffff8b16a70b (/lib/aarch64-linux-gnu/libc.so.6+0xcf70b)
SUMMARY: AddressSanitizer: 24 byte(s) leaked in 1 allocation(s).
iamluc
added a commit
that referenced
this pull request
May 27, 2024
Direct leak of 24 byte(s) in 1 object(s) allocated from:
#0 0xffff8dfed43b in malloc (/usr/lib/aarch64-linux-gnu/libasan.so.5+0xcf43b)
#1 0xffff81eb8f4f in __cxa_thread_atexit_impl /home/circleci/datadog/tmp/build_extension/ext/ddtrace.c:560
#2 0xffff82ed7c8b in std::sys::unix::thread_local_dtor::register_dtor::ha7abe21b2e8f0491 library/std/src/sys/unix/thread_local_dtor.rs:31
#3 0xffff81ec332b in _dd_writer_loop /home/circleci/datadog/tmp/build_extension/ext/coms.c:1053
#4 0xffff8db7a7e3 in start_thread /build/glibc-tVuo8E/glibc-2.28/nptl/pthread_create.c:486
#5 0xffff8b16a70b (/lib/aarch64-linux-gnu/libc.so.6+0xcf70b)
SUMMARY: AddressSanitizer: 24 byte(s) leaked in 1 allocation(s).
bwoebi
added a commit
that referenced
this pull request
May 28, 2024
…nd trace sender (#2672) * Make use of the sidecar thread safe * Collect trace_api.{requests,responses,errors} in the background trace sender * Fix test * Fix memory leak: Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0xffff8dfed43b in malloc (/usr/lib/aarch64-linux-gnu/libasan.so.5+0xcf43b) #1 0xffff81eb8f4f in __cxa_thread_atexit_impl /home/circleci/datadog/tmp/build_extension/ext/ddtrace.c:560 #2 0xffff82ed7c8b in std::sys::unix::thread_local_dtor::register_dtor::ha7abe21b2e8f0491 library/std/src/sys/unix/thread_local_dtor.rs:31 #3 0xffff81ec332b in _dd_writer_loop /home/circleci/datadog/tmp/build_extension/ext/coms.c:1053 #4 0xffff8db7a7e3 in start_thread /build/glibc-tVuo8E/glibc-2.28/nptl/pthread_create.c:486 #5 0xffff8b16a70b (/lib/aarch64-linux-gnu/libc.so.6+0xcf70b) SUMMARY: AddressSanitizer: 24 byte(s) leaked in 1 allocation(s). * Update libdatadog * Fix tests * Try running system tests with sidecar sender Signed-off-by: Bob Weinand <[email protected]> * Don't explicitly flush the bgs telemetry data * Improve test stability * Try to run system-tests from a fork * Fix telemetry tests * Shut up instrumentation telemetry in web tests * Fix flakiness Signed-off-by: Bob Weinand <[email protected]> * Better flaky test check Signed-off-by: Bob Weinand <[email protected]> --------- Signed-off-by: Bob Weinand <[email protected]> Co-authored-by: Bob Weinand <[email protected]>
2 tasks
leoromanovsky
added a commit
that referenced
this pull request
Feb 11, 2026
Update libdatadog submodule to include: - feat: Add FFE_FLAGS remote config product and capability (#1532) This adds RemoteConfigProduct::FfeFlags, RemoteConfigCapabilities:: FfeFlagConfigurationRules, and RemoteConfigData::FfeFlags to the remote config layer. Required for the PHP FFE integration (PR #2). Cargo.lock regenerated with pins for CI compatibility: home→0.5.9, rmp→0.8.14, rmp-serde→1.3.0 (edition2024 crates).
leoromanovsky
added a commit
that referenced
this pull request
Feb 12, 2026
Update libdatadog submodule to include: - feat: Add FFE_FLAGS remote config product and capability (#1532) This adds RemoteConfigProduct::FfeFlags, RemoteConfigCapabilities:: FfeFlagConfigurationRules, and RemoteConfigData::FfeFlags to the remote config layer. Required for the PHP FFE integration (PR #2). Cargo.lock regenerated with pins for CI compatibility: home→0.5.9, rmp→0.8.14, rmp-serde→1.3.0 (edition2024 crates).
leoromanovsky
added a commit
that referenced
this pull request
Feb 12, 2026
Update libdatadog submodule to include: - feat: Add FFE_FLAGS remote config product and capability (#1532) This adds RemoteConfigProduct::FfeFlags, RemoteConfigCapabilities:: FfeFlagConfigurationRules, and RemoteConfigData::FfeFlags to the remote config layer. Required for the PHP FFE integration (PR #2). Cargo.lock regenerated with pins for CI compatibility: home→0.5.9, rmp→0.8.14, rmp-serde→1.3.0 (edition2024 crates).
leoromanovsky
added a commit
that referenced
this pull request
Apr 21, 2026
…er PR #3630 review Addresses all outstanding reviewer feedback from #3630: bwoebi: - Blocker #1: Route exposures through sidecar, zero HTTP from PHP main thread. Implements Rust ExposureState with 65K-entry LRU dedup + 1000-event batch buffer. PHP ExposureWriter uses injectable sidecarCallable routing to DDTrace\ffe_send_exposure() — fire-and-forget, never blocks evaluation. - Blocker #2: Proper documented functions in ddtrace.stub.php (not dd_trace_internal_fn). Eight DDTrace\ffe_* functions declared with PHPDoc @internal: ffe_evaluate, ffe_has_config, ffe_config_changed, ffe_load_config, ffe_send_exposure, ffe_flush_exposures, ffe_set_service_context, ffe_reset_exposure_state. Each has PHP_FUNCTION impl + arginfo + registration. - emalloc/ecalloc memory hygiene and C99 brace style consistent with existing dd-trace-php conventions. - Fire-and-forget: DataDogProvider::resolveViaFfe() invokes exposureWriter->send() and ignores return. No exception propagates from exposure path to evaluation. - Primitive-only attribute filtering in EvaluationContextNormalizer mirrors the C-side filter in ffe_evaluate (drops arrays, nulls, objects, resources). dd-oleksii: - Null targeting key preserved end-to-end (not coerced to empty string). EvaluationContextNormalizer returns [?string, array]. - do_log per-allocation hard gate: ExposureContext::fromBridgeResult() returns null when do_log=false; provider skips exposure send. - OTel feature_flag.evaluations counter with OBSV-02 attributes (key, variant, reason, error.type, allocation_key). MetricsCounter injectable callable, no open-telemetry/api composer dep per CLAUDE.md. Gated on DD_METRICS_OTEL_ENABLED. Fires on every evaluation including errors. - PR split into four independently-reviewable phases (roadmap in staging repo). realFlowControl: - ZTS per-thread FFE state: declined for v1 (NTS-only per PROJECT.md). Global Mutex<FfeState> is correct for NTS. Tracked as v2 requirement. Architecture changes: - Remove src/DDTrace/FeatureFlags/ (old in-process HTTP architecture). LRUCache.php, ExposureCache.php, ExposureWriter.php, Provider.php, FlagEvalMetrics.php — all replaced by Rust-sidecar pipeline. - Remove tests/FeatureFlags/ (tests covered by staging PHPUnit suite). - Add src/DDTrace/OpenFeature/ with 9 classes: BridgeResultMapper, ContextFlattener, DataDogProvider (rewritten), EvaluationContextNormalizer, ExposureContext, ExposureWriter, MetricsCounter, OpenFeatureLifecycleCompatibility, ProviderLifecycle. - Add tests/OpenFeature/ with 7 test files, 143 tests. - components-rs/ffe.rs: add ExposureState + extern C functions for enqueue_exposure, flush_exposures, set_service_context, reset_exposure_state, free_flush_result. Uses lru crate 0.12. - components-rs/Cargo.toml: add lru = "0.12". - composer.json: add open-feature/sdk ^2.1 as require-dev. - src/bridge/_files_tracer.php: load new OpenFeature files, remove FeatureFlags. Verification: 143/143 staging PHPUnit tests pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the Span class and a basic tracer.
Ping @palazzem