[Profiling] Raise max stack depth to 512#1681
Merged
Merged
Conversation
The exact fake frame name may change to align with other profilers, but currently this information is missing and we can't easily tell if a customer has hit a stalk walking bug, genuinely has weird stacks, or if it's been truncated.
Some customers are seeing truncated stacks. This PR allows going up to 512 frames deep now but it no longer allocates the max stack depth when initializing samples buffer. This avoids waste when the stack is much smaller than the limit, which it very often is.
morrisonlevi
added
🏆 enhancement
morrisonlevi
marked this pull request as ready for review
August 1, 2022 16:13
r1viollet
reviewed
Aug 1, 2022
| let max_depth = 128; | ||
| samples.reserve(max_depth); // todo: try_reserve | ||
| let max_depth = 512; | ||
| let mut samples = Vec::with_capacity(max_depth >> 3); |
Collaborator
There was a problem hiding this comment.
Minor: We could explicitly write the reserve size
Collaborator
Author
There was a problem hiding this comment.
We could, but then we should probably assert it is less than max_depth. Didn't seem worth it.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some customers are seeing truncated stacks. This PR allows going up
to 512 frames deep now but it no longer allocates the max stack depth
when initializing samples buffer. This avoids waste when the stack is
much smaller than the limit, which it very often will be with a higher
limit.
Readiness checklist
Reviewer checklist