Add "recurse" => true option to hook/trace config array#1677
Merged
Conversation
Thus, it is now possible to write code like
DDTrace\hook_function('greet', [
'prehook' => function ($args) {
echo "greet prehook: {$args[0]}\n";
},
'posthook' => function ($args) {
echo "greet posthook: {$args[0]}\n";
},
'recurse' => true
]);
to have traces also trigger upon recursion
Signed-off-by: Bob Weinand <[email protected]>
Collaborator
There was a problem hiding this comment.
What you have looks fine, but from experience we should also add a test for something like some class extending Pdo::exec that calls parent::exec as part of its exec.
Also, we should update the Symfony integration to allow recursion for the event handler hooks if possible. This part doesn't have to be in this PR, though.
morrisonlevi
approved these changes
Jul 29, 2022
morrisonlevi
left a comment
morrisonlevi
left a comment
Collaborator
There was a problem hiding this comment.
Chatted with Bob; the test I wanted is irrelevant now due to some other changes I missed. Looks good.
4 tasks
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Thus, it is now possible to write code like
to have traces also trigger upon recursion
Fixes #1105.
Readiness checklist
Reviewer checklist