Add support for ports on x-forwarded-for header#1675
Merged
estringana merged 4 commits intoJul 29, 2022
Conversation
According to [Azzure Application Gateway documentation](https://docs.microsoft.com/en-us/azure/application-gateway/how-application-gateway-works#modifications-to-the-request) the IPs on x-forwarded-for header can contain the port. Our ip extraction code was not expeting ports as part of this header. This PR fixes #1672
Anilm3
reviewed
Jul 28, 2022
Anilm3
reviewed
Jul 28, 2022
Anilm3
reviewed
Jul 28, 2022
bwoebi
approved these changes
Jul 29, 2022
bwoebi
left a comment
bwoebi
left a comment
Collaborator
There was a problem hiding this comment.
I think we've now arrived at the simplest possible implementation, LGTM :-)
estringana
marked this pull request as ready for review
July 29, 2022 12:03
estringana
deleted the
estringana/support-ports-on-x-forwarded-for-header
branch
July 29, 2022 12:04
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to Azzure Application Gateway documentation the IPs on x-forwarded-for header
can contain the port. Our ip extraction code was not expeting ports as part of this header.
This PR fixes #1672
Description
Readiness checklist
Reviewer checklist