Skip to content

Fix JIT compatibility under macOS#1661

Merged
bwoebi merged 1 commit into
masterfrom
bob/fix-macos-jit-compat
Jul 19, 2022
Merged

Fix JIT compatibility under macOS#1661
bwoebi merged 1 commit into
masterfrom
bob/fix-macos-jit-compat

Conversation

@bwoebi

@bwoebi bwoebi commented Jul 19, 2022

Copy link
Copy Markdown
Collaborator

Description

The code was accessing the opcache handle after it has been set to zero as part of accel_startup().
Under glibc (at least), passing NULL to dlsym() will find opcaches symbols. Under mac it does not.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug.

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@bwoebi
bwoebi requested a review from a team as a code owner July 19, 2022 03:11
@bwoebi bwoebi added this to the 0.77.0 milestone Jul 19, 2022
@bwoebi
bwoebi merged commit 34873d6 into master Jul 19, 2022
@bwoebi
bwoebi deleted the bob/fix-macos-jit-compat branch July 19, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants