Skip to content

Move mapping-settings to be deserialized as a zend_array *#1253

Merged
bwoebi merged 1 commit intomasterfrom
bob/hash-config
Jun 8, 2021
Merged

Move mapping-settings to be deserialized as a zend_array *#1253
bwoebi merged 1 commit intomasterfrom
bob/hash-config

Conversation

@bwoebi
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi commented Jun 8, 2021

Required for the internal spans, as they'll need to access these.

Split out from #1251.

Readiness checklist

  • (only for Members) Changelog has been added to the release document.
  • Tests added for this feature/bug. (Covered by the changed tests)

Reviewer checklist

  • Appropriate labels assigned.
  • Milestone is set.
  • Changelog has been added to the release document. For community contributors the reviewer is in charge of this task.

@bwoebi bwoebi added the c-extension Apply this label to issues and prs related to the C-extension label Jun 8, 2021
@bwoebi bwoebi added this to the 0.61.0 milestone Jun 8, 2021
@bwoebi bwoebi force-pushed the bob/hash-config branch from 08f1cc5 to 4139b7d Compare June 8, 2021 16:36
Required for the internal spans, as they'll need to access these.

Signed-off-by: Bob Weinand <[email protected]>
@bwoebi bwoebi force-pushed the bob/hash-config branch from 4139b7d to be3a757 Compare June 8, 2021 16:49
@bwoebi bwoebi requested a review from SammyK June 8, 2021 16:50
Copy link
Copy Markdown
Contributor

@SammyK SammyK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM. Thanks for splitting this out @bwoebi! We'll migrate this into ZAI config.

@bwoebi bwoebi merged commit fe830c0 into master Jun 8, 2021
@bwoebi bwoebi deleted the bob/hash-config branch June 8, 2021 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c-extension Apply this label to issues and prs related to the C-extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants