Conversation
bwoebi
force-pushed
the
bob/zai/properties
branch
2 times, most recently
from
75e8635 to
3b08f8f
Compare
| $<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}> | ||
| $<INSTALL_INTERFACE:include>) | ||
|
|
||
| target_compile_features(zai_properties PUBLIC c_std_99) |
Collaborator
There was a problem hiding this comment.
I was expecting this to be either INTERFACE c_std_99 PRIVATE c_std_11 or PUBLIC c_std_11 -- any specific reason for choosing C99?
Collaborator
Author
There was a problem hiding this comment.
just copy paste from the other CMakeLists. Doesn't really matter as long as it compiles?
SammyK
reviewed
May 27, 2021
SammyK
changed the title
bwoebi
force-pushed
the
bob/zai/properties
branch
2 times, most recently
from
72e4512 to
12efb38
Compare
Signed-off-by: Bob Weinand <[email protected]>
bwoebi
force-pushed
the
bob/zai/properties
branch
from
12efb38 to
119565a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A simple function allowing direct access into userland (and internal classes without very special property storage) properties, bypassing __get() and similar.
Readiness checklist
Reviewer checklist