Merged
Conversation
SammyK
reviewed
May 28, 2021
Contributor
SammyK
left a comment
SammyK
left a comment
There was a problem hiding this comment.
LGTM! 👍 Nice work @Anilm3.
Before marking approve, one tiny nit on the API (cc @labbati): WDYT of dropping the get_ prefix: \DDTrace\current_context(). That would make it more consistent with existing getter functions. e.g.:
\DDTrace\trace_id()\DDTrace\additional_trace_meta()\DDTrace\startup_logs()
No strong opinion either way though. :)
Member
Sounds good to me! Thank you both! |
Contributor
Author
|
@SammyK, thanks, as suggested I've renamed |
SammyK
approved these changes
Jun 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Readiness checklist
Reviewer checklist