Disable PCNTL in forked processes#1196
Merged
Merged
Conversation
labbati
added
the
c-extension
labbati
force-pushed
the
labbati/pcntl-no-hang
branch
from
April 9, 2021 10:01
42605c8 to
f6846d1
Compare
5 tasks
labbati
force-pushed
the
labbati/pcntl-no-hang
branch
from
April 13, 2021 16:31
5ca53cd to
4420408
Compare
labbati
force-pushed
the
labbati/pcntl-no-hang
branch
from
April 14, 2021 12:44
4420408 to
f7730f0
Compare
labbati
commented
Apr 14, 2021
| - PHP_IDE_CONFIG=serverName=docker | ||
| cap_add: | ||
| - SYS_PTRACE | ||
| # Privileged is requires to run some pcntl tests locally. |
Member
Author
There was a problem hiding this comment.
I added it here. The hope is that after I pass over it for 100 times, I will remember to enable it when I need to run the whole pcntl php language tests suite :D (which runs in CI)
labbati
force-pushed
the
labbati/pcntl-no-hang
branch
from
April 21, 2021 13:14
f7730f0 to
fca5bf5
Compare
labbati
force-pushed
the
labbati/pcntl-no-hang
branch
2 times, most recently
from
April 22, 2021 14:24
9882815 to
c138755
Compare
5 tasks
labbati
force-pushed
the
labbati/pcntl-no-hang
branch
2 times, most recently
from
April 23, 2021 16:49
2984d00 to
bd845ab
Compare
labbati
force-pushed
the
labbati/pcntl-no-hang
branch
from
April 23, 2021 20:30
bd845ab to
a4e4b86
Compare
labbati
force-pushed
the
labbati/pcntl-no-hang
branch
from
April 26, 2021 09:11
a4e4b86 to
8aa302d
Compare
…obals for loaded modules
…pcntl manual tests
…pcntl manual tests (followup)
…ibility of mixed printf when pcntl
…t tests (followup)
…t tests (followup)
…t tests (followup)
…t tests (followup)
SammyK
reviewed
May 4, 2021
SammyK
left a comment
SammyK
left a comment
Contributor
There was a problem hiding this comment.
I think once the microtime issue is squared away, this should be good to go!
Member
Author
|
@SammyK good catch on the time units in test. Just fixes it, do you mind taking a final look? |
Member
Author
|
Thanks @SammyK |
bwoebi
added a commit
that referenced
this pull request
Sep 1, 2025
Also avoid retrying a trace flush, that's pretty much pointless. Signed-off-by: Bob Weinand <[email protected]>
bwoebi
added a commit
that referenced
this pull request
Sep 2, 2025
Also avoid retrying a trace flush, that's pretty much pointless. Signed-off-by: Bob Weinand <[email protected]>
bwoebi
added a commit
that referenced
this pull request
Sep 4, 2025
Also avoid retrying a trace flush, that's pretty much pointless. Signed-off-by: Bob Weinand <[email protected]>
bwoebi
added a commit
that referenced
this pull request
Sep 22, 2025
Also avoid retrying a trace flush, that's pretty much pointless. Signed-off-by: Bob Weinand <[email protected]>
bwoebi
added a commit
that referenced
this pull request
Sep 29, 2025
* Clean shutdown of sidecar on SIGTERM (#1196) Also avoid retrying a trace flush, that's pretty much pointless. Signed-off-by: Bob Weinand <[email protected]> * Update libdatadog Signed-off-by: Bob Weinand <[email protected]> --------- Signed-off-by: Bob Weinand <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation:
pcntlinstalled (even when CLI tracing is not enabled) causes a delay of 5 seconds when the script exits (#1158)What does this PR do?: it temporarily disable tracing on the forked process. Once we will use internal spans as the underlying mechanism for userland spans, as well, then we can support pcntl_fork properly.
Readiness checklist
Reviewer checklist