fix(ci): exit 1 on datadog-ci upload failure so silent wrapper shows output

Leiyks · Leiyks · commit f9b6b32b3320 · 2026-04-16T13:54:06.000+02:00
diff --git a/.gitlab/silent-upload-junit-to-datadog.sh b/.gitlab/silent-upload-junit-to-datadog.sh
@@ -1,8 +1,10 @@
 #!/bin/bash
 OUTFILE=/tmp/datadog-junit-upload.txt
 "$(dirname -- "${BASH_SOURCE[0]}")"/upload-junit-to-datadog.sh "$@" >$OUTFILE 2>&1
-if [[ $? -ne 0 ]]; then
+rc=$?
+if [[ $rc -ne 0 ]]; then
   cat $OUTFILE
 else
   grep -E '^\* ' $OUTFILE
 fi
+exit $rc
diff --git a/.gitlab/upload-junit-to-datadog.sh b/.gitlab/upload-junit-to-datadog.sh
@@ -215,8 +215,8 @@ echo "Current directory: $(pwd)"
 echo "Running command: ${datadog_ci_cmd} junit upload --service \"${DD_SERVICE}\" --max-concurrency 20 --verbose --tags git.repository_url:https://github.com/DataDog/dd-trace-php ${tags_args} ${xpath_tags_args} ${files_array[*]}"
 
 if ! ${datadog_ci_cmd} junit upload --service "${DD_SERVICE}" --max-concurrency 20 --verbose --tags "git.repository_url:https://github.com/DataDog/dd-trace-php" ${tags_args} ${xpath_tags_args} "${files_array[@]}"; then
-  echo "Warning: Failed to upload JUnit files" >&2
-  exit 0
+  echo "Error: Failed to upload JUnit files" >&2
+  exit 1
 fi
 
 echo "=== JUnit upload completed ==="
