DEBUG: do we hit frameless icalls?

morrisonlevi · morrisonlevi · commit e16e1b107a30 · 2026-01-13T18:05:47.000-07:00
diff --git a/profiling/src/profiling/stack_walking.rs b/profiling/src/profiling/stack_walking.rs
@@ -169,6 +169,24 @@ unsafe fn extract_file_and_line(
 #[inline]
 fn frameless_opline_or_prev(execute_data: &zend_execute_data) -> Option<&zend_op> {
     let opline = safely_get_opline(execute_data)?;
+    if matches!(
+        opline.opcode as u32,
+        ZEND_FRAMELESS_ICALL_0
+            | ZEND_FRAMELESS_ICALL_1
+            | ZEND_FRAMELESS_ICALL_2
+            | ZEND_FRAMELESS_ICALL_3
+    ) {
+        // Debug aid: crash hard when we observe a frameless icall as the current opline.
+        // If this never triggers in CI, then allocation sampling is not observing the
+        // frameless opcode as the current execute_data->opline at sample time.
+        panic!(
+            "Observed FRAMELESS_ICALL opcode ({}) as current opline at execute_data={:p} opline={:p} extended_value={}",
+            opline.opcode as u32,
+            execute_data,
+            execute_data.opline,
+            opline.extended_value
+        );
+    }
     if opline.opcode as u32 != ZEND_OP_DATA {
         return Some(opline);
     }
@@ -212,7 +230,6 @@ fn frameless_opline_or_prev(execute_data: &zend_execute_data) -> Option<&zend_op
                 execute_data.opline,
                 prev_ptr
             );
-            Some(prev)
         }
         _ => Some(opline),
     }
