Merge pull request #3496 from DataDog/glopes/stale-client-ip

cataphract · web-flow · commit ddced7cfa7a8 · 2025-11-24T15:19:00.000Z
Clear client_ip on request_init
diff --git a/appsec/src/extension/request_lifecycle.c b/appsec/src/extension/request_lifecycle.c
@@ -118,6 +118,13 @@ void dd_req_lifecycle_rinit(bool force)
     if (!_cur_req_span) {
         mlog(dd_log_debug, "No root span available on request init");
     }
+
+    if (_client_ip) {
+        mlog(dd_log_warning, "Client IP not cleared on prev request. Value %p",
+            (void *)_client_ip);
+        _client_ip = NULL;
+    }
+
     _do_request_begin_php();
 }
 

Original file line number	Diff line number	Diff line change
`@@ -118,6 +118,13 @@ void dd_req_lifecycle_rinit(bool force)`
`118`	`118`	`if (!_cur_req_span) {`
`119`	`119`	`mlog(dd_log_debug, "No root span available on request init");`
`120`	`120`	`}`
	`121`	`+`
	`122`	`+ if (_client_ip) {`
	`123`	`+ mlog(dd_log_warning, "Client IP not cleared on prev request. Value %p",`
	`124`	`+ (void *)_client_ip);`
	`125`	`+ _client_ip = NULL;`
	`126`	`+ }`
	`127`	`+`
`121`	`128`	`_do_request_begin_php();`
`122`	`129`	`}`
`123`	`130`