Skip to content

Commit bfb7ae6

Browse files
committed
fix(telemetry): cap dependency name length to copied bytes
1 parent 2fa9b2e commit bfb7ae6

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

ext/telemetry.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,10 +144,11 @@ void ddtrace_telemetry_finalize() {
144144
char module_name[261] = { 'e', 'x', 't', '-' };
145145
ZEND_HASH_FOREACH_PTR(&module_registry, module) {
146146
size_t namelen = strlen(module->name);
147-
memcpy(module_name + 4, module->name, MIN(256, strlen(module->name)));
147+
size_t copylen = MIN(256, namelen);
148+
memcpy(module_name + 4, module->name, copylen);
148149
const char *version = module->version ? module->version : "";
149150
ddog_sidecar_telemetry_addDependency_buffer(buffer,
150-
(ddog_CharSlice) {.len = namelen + 4, .ptr = module_name},
151+
(ddog_CharSlice) {.len = copylen + 4, .ptr = module_name},
151152
(ddog_CharSlice) {.len = strlen(version), .ptr = version});
152153
} ZEND_HASH_FOREACH_END();
153154

0 commit comments

Comments
 (0)