fix(mongodb): Deprecated exception in v1.20+ (#2870)

PROFeNoM · web-flow · commit bb96a538c9f7 · 2024-10-04T10:27:43.000+02:00
diff --git a/src/DDTrace/Integrations/MongoDB/MongoDBIntegration.php b/src/DDTrace/Integrations/MongoDB/MongoDBIntegration.php
@@ -17,13 +17,25 @@ function register_subscriber()
 {
     class DatadogSubscriber implements \MongoDB\Driver\Monitoring\CommandSubscriber
     {
+        private static $useDeprecatedMethods = null;
+
         #[\ReturnTypeWillChange]
         public function commandStarted(\MongoDB\Driver\Monitoring\CommandStartedEvent $event)
         {
             $span = \DDTrace\active_span();
             if ($span) {
-                $span->meta['out.host'] = $event->getServer()->getHost();
-                $span->meta['out.port'] = $event->getServer()->getPort();
+                if (is_null(self::$useDeprecatedMethods)) {
+                    // v1.20+: getServer() is deprecated in favor of getHost() and getPort()
+                    self::$useDeprecatedMethods = !method_exists($event, 'getHost') || method_exists($event, 'getPort');
+                }
+
+                if (self::$useDeprecatedMethods) {
+                    $span->meta['out.host'] = $event->getServer()->getHost();
+                    $span->meta['out.port'] = $event->getServer()->getPort();
+                } else {
+                    $span->meta['out.host'] = $event->getHost();
+                    $span->meta['out.port'] = $event->getPort();
+                }
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -17,13 +17,25 @@ function register_subscriber()`
`17`	`17`	`{`
`18`	`18`	`class DatadogSubscriber implements \MongoDB\Driver\Monitoring\CommandSubscriber`
`19`	`19`	`{`
	`20`	`+ private static $useDeprecatedMethods = null;`
	`21`	`+`
`20`	`22`	`#[\ReturnTypeWillChange]`
`21`	`23`	`public function commandStarted(\MongoDB\Driver\Monitoring\CommandStartedEvent $event)`
`22`	`24`	`{`
`23`	`25`	`$span = \DDTrace\active_span();`
`24`	`26`	`if ($span) {`
`25`		`- $span->meta['out.host'] = $event->getServer()->getHost();`
`26`		`- $span->meta['out.port'] = $event->getServer()->getPort();`
	`27`	`+ if (is_null(self::$useDeprecatedMethods)) {`
	`28`	`+ // v1.20+: getServer() is deprecated in favor of getHost() and getPort()`
	`29`	`+ self::$useDeprecatedMethods = !method_exists($event, 'getHost') \|\| method_exists($event, 'getPort');`
	`30`	`+ }`
	`31`	`+`
	`32`	`+ if (self::$useDeprecatedMethods) {`
	`33`	`+ $span->meta['out.host'] = $event->getServer()->getHost();`
	`34`	`+ $span->meta['out.port'] = $event->getServer()->getPort();`
	`35`	`+ } else {`
	`36`	`+ $span->meta['out.host'] = $event->getHost();`
	`37`	`+ $span->meta['out.port'] = $event->getPort();`
	`38`	`+ }`
`27`	`39`	`}`
`28`	`40`	`}`
`29`	`41`