Skip to content

Commit b436003

Browse files
committed
Fix cbindgen
1 parent 8b3ba1b commit b436003

6 files changed

Lines changed: 8 additions & 33 deletions

File tree

Cargo.lock

Lines changed: 2 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cbindgen.toml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,3 @@ rename_variants = "ScreamingSnakeCase"
2626
[parse]
2727
parse_deps = true
2828
include = ["ddcommon", "ddtelemetry", "ddcommon-ffi", "ddtelemetry-ffi", "datadog-sidecar", "datadog-ipc", "uuid"]
29-
30-
[parse.expand]
31-
crates = ["ddtrace-php"]

components-rs/Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ path = "lib.rs"
99

1010
[dependencies]
1111
ddcommon = { path = "../libdatadog/ddcommon" }
12-
ddcommon-ffi = { path = "../libdatadog/ddcommon-ffi" }
12+
ddcommon-ffi = { path = "../libdatadog/ddcommon-ffi", default-features = false }
1313
ddtelemetry = { path = "../libdatadog/ddtelemetry" }
14-
ddtelemetry-ffi = { path = "../libdatadog/ddtelemetry-ffi" }
14+
ddtelemetry-ffi = { path = "../libdatadog/ddtelemetry-ffi", default-features = false }
1515
datadog-sidecar = { path = "../libdatadog/sidecar" }
1616
datadog-sidecar-ffi = { path = "../libdatadog/sidecar-ffi" }
1717
spawn_worker = { path = "../libdatadog/spawn_worker" }
@@ -33,4 +33,4 @@ tracing-subscriber = { version = "0.3", default-features = false, features = [
3333
] }
3434

3535
[build-dependencies]
36-
cbindgen = "0.24"
36+
cbindgen = "0.26"

components-rs/ddtrace.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@ extern ddog_Uuid ddtrace_runtime_id;
121121

122122
extern void (*ddog_log_callback)(ddog_CharSlice);
123123

124+
extern const uint8_t *DDOG_PHP_FUNCTION;
125+
124126
/**
125127
* # Safety
126128
* Must be called from a single-threaded context, such as MINIT.

ext/sidecar.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@ static void ddtrace_set_sidecar_globals(void) {
1919
ddtrace_sidecar_instance_id = ddog_sidecar_instanceId_build(session_id, runtime_id);
2020
}
2121

22-
// Windows only defines do not appear in cbindgen
23-
#ifdef WIN32
24-
extern const uint8_t *DDOG_PHP_FUNCTION;
25-
#endif
26-
2722
static bool dd_sidecar_connection_init(void) {
2823
if (get_global_DD_TRACE_AGENTLESS() && ZSTR_LEN(get_global_DD_API_KEY())) {
2924
ddtrace_endpoint = ddog_endpoint_from_api_key(dd_zend_string_to_CharSlice(get_global_DD_API_KEY()));

0 commit comments

Comments
 (0)