Normalize sample rates to 0..1

bwoebi · bwoebi · commit 9b043e71c4c7 · 2026-05-28T15:36:45.000+02:00
Avoiding bad knuth hash computation etc.
diff --git a/ext/priority_sampling/priority_sampling.c b/ext/priority_sampling/priority_sampling.c
@@ -331,6 +331,12 @@ static void dd_decide_on_sampling(ddtrace_root_span_data *span) {
         sample_rate = result.sampling_rate;
     }
 
+    if (sample_rate > 1) {
+        sample_rate = 1;
+    } else if (sample_rate < 0) {
+        sample_rate = 0;
+    }
+
     // this must be stable on re-evaluation
     bool sampling = (span->trace_id.low * KNUTH_FACTOR) <= (sample_rate * MAX_TRACE_ID);
     bool limited = false;
