Fix duration of httpstream and live debugger spans (#3821)

bwoebi · web-flow · commit 96c5f06b358c · 2026-04-24T13:09:16.000+02:00
diff --git a/ext/handlers_httpstreams.c b/ext/handlers_httpstreams.c
@@ -116,6 +116,7 @@ static php_stream *dd_stream_opener(
     }
 
     if (span) {
+        dd_trace_stop_span_time(span);
         ddtrace_clear_execute_data_span((zend_ulong)-2, true);
     }
 
diff --git a/ext/live_debugger.c b/ext/live_debugger.c
@@ -263,6 +263,7 @@ static void dd_span_probe_end(zend_ulong invocation, zend_execute_data *execute_
     UNUSED(execute_data, retval, auxiliary);
 
     if (dyn->span) {
+        dd_trace_stop_span_time(dyn->span);
         ddtrace_clear_execute_data_span(invocation, true);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -116,6 +116,7 @@ static php_stream *dd_stream_opener(`
`116`	`116`	`}`
`117`	`117`
`118`	`118`	`if (span) {`
	`119`	`+ dd_trace_stop_span_time(span);`
`119`	`120`	`ddtrace_clear_execute_data_span((zend_ulong)-2, true);`
`120`	`121`	`}`
`121`	`122`
Original file line number	Diff line number	Diff line change
`@@ -263,6 +263,7 @@ static void dd_span_probe_end(zend_ulong invocation, zend_execute_data *execute_`
`263`	`263`	`UNUSED(execute_data, retval, auxiliary);`
`264`	`264`
`265`	`265`	`if (dyn->span) {`
	`266`	`+ dd_trace_stop_span_time(dyn->span);`
`266`	`267`	`ddtrace_clear_execute_data_span(invocation, true);`
`267`	`268`	`}`
`268`	`269`	`}`