fix test_collect_stack_sample not running

realFlowControl · realFlowControl · commit 893a3b433c5c · 2026-02-02T09:35:13.000+01:00
diff --git a/profiling/src/php_ffi.c b/profiling/src/php_ffi.c
@@ -534,6 +534,10 @@ void ddog_php_test_free_fake_zend_function(zend_function *func) {
     free(func->common.function_name);
     free(func);
 }
+
+// Stub for zend_flf_functions (PHP 8.4+ frameless calls) to allow tests to link
+// without the real PHP runtime. The test doesn't exercise frameless code paths.
+__attribute__((weak)) zend_function **zend_flf_functions;
 #endif // CFG_STACK_WALKING_TESTS || CFG_TEST
 
 void *opcache_handle = NULL;
diff --git a/profiling/src/profiling/stack_walking.rs b/profiling/src/profiling/stack_walking.rs
@@ -542,7 +542,7 @@ mod tests {
     }
 
     #[test]
-    #[cfg(stack_walking_tests)]
+    #[cfg(feature = "stack_walking_tests")]
     fn test_collect_stack_sample() {
         unsafe {
             let fake_execute_data = zend::ddog_php_test_create_fake_zend_execute_data(3);

Original file line number	Diff line number	Diff line change
`@@ -542,7 +542,7 @@ mod tests {`
`542`	`542`	`}`
`543`	`543`
`544`	`544`	`#[test]`
`545`		`- #[cfg(stack_walking_tests)]`
	`545`	`+ #[cfg(feature = "stack_walking_tests")]`
`546`	`546`	`fn test_collect_stack_sample() {`
`547`	`547`	`unsafe {`
`548`	`548`	`let fake_execute_data = zend::ddog_php_test_create_fake_zend_execute_data(3);`