Fix int type: we must support signed numbers

iamluc · iamluc · commit 51fbd865a981 · 2024-05-17T09:26:52.000+02:00
diff --git a/components-rs/sidecar.h b/components-rs/sidecar.h
@@ -143,7 +143,7 @@ ddog_CharSlice ddog_sidecar_stats(ddog_SidecarTransport **transport);
 ddog_MaybeError ddog_sidecar_dogstatsd_count(ddog_SidecarTransport **transport,
                                              const struct ddog_InstanceId *instance_id,
                                              ddog_CharSlice metric,
-                                             uint64_t value,
+                                             int64_t value,
                                              const struct ddog_Vec_Tag *tags);
 
 ddog_MaybeError ddog_sidecar_dogstatsd_distribution(ddog_SidecarTransport **transport,
@@ -167,7 +167,7 @@ ddog_MaybeError ddog_sidecar_dogstatsd_histogram(ddog_SidecarTransport **transpo
 ddog_MaybeError ddog_sidecar_dogstatsd_set(ddog_SidecarTransport **transport,
                                            const struct ddog_InstanceId *instance_id,
                                            ddog_CharSlice metric,
-                                           uint64_t value,
+                                           int64_t value,
                                            const struct ddog_Vec_Tag *tags);
 
 #endif /* DDOG_SIDECAR_H */
diff --git a/ext/sidecar.c b/ext/sidecar.c
@@ -166,7 +166,7 @@ void ddtrace_sidecar_dogstatsd_count(zend_string *metric, zend_long value, zval
 
     ddog_Vec_Tag vec = ddog_Vec_Tag_new();
     ddtrace_sidecar_dogstatsd_push_tags(&vec, tags);
-    ddog_sidecar_dogstatsd_count(&ddtrace_sidecar, ddtrace_sidecar_instance_id, dd_zend_string_to_CharSlice(metric), (uint64_t)value, &vec);
+    ddog_sidecar_dogstatsd_count(&ddtrace_sidecar, ddtrace_sidecar_instance_id, dd_zend_string_to_CharSlice(metric), value, &vec);
     ddog_Vec_Tag_drop(vec);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -166,7 +166,7 @@ void ddtrace_sidecar_dogstatsd_count(zend_string *metric, zend_long value, zval`
`166`	`166`
`167`	`167`	`ddog_Vec_Tag vec = ddog_Vec_Tag_new();`
`168`	`168`	`ddtrace_sidecar_dogstatsd_push_tags(&vec, tags);`
`169`		`- ddog_sidecar_dogstatsd_count(&ddtrace_sidecar, ddtrace_sidecar_instance_id, dd_zend_string_to_CharSlice(metric), (uint64_t)value, &vec);`
	`169`	`+ ddog_sidecar_dogstatsd_count(&ddtrace_sidecar, ddtrace_sidecar_instance_id, dd_zend_string_to_CharSlice(metric), value, &vec);`
`170`	`170`	`ddog_Vec_Tag_drop(vec);`
`171`	`171`	`}`
`172`	`172`