fix(config): use fresh buffer for env_config_fallback to prevent buffer reuse

morrisonlevi · morrisonlevi · commit 433ca6085ff7 · 2026-03-31T14:08:14.000-06:00
diff --git a/zend_abstract_interface/config/config.c b/zend_abstract_interface/config/config.c
@@ -99,9 +99,11 @@ static void zai_config_find_and_set_value(zai_config_memoized_entry *memoized, z
             break;
         }
     }
-    if (!value.len && memoized->env_config_fallback && memoized->env_config_fallback(&buf, true)) {
-        zai_config_process_env(memoized, buf, &value);
+    ZAI_ENV_BUFFER_INIT(fallback_buf, ZAI_ENV_MAX_BUFSIZ);
+    if (!value.len && memoized->env_config_fallback && memoized->env_config_fallback(&fallback_buf, true)) {
+        zai_config_process_env(memoized, fallback_buf, &value);
         name_index = ZAI_CONFIG_ORIGIN_MODIFIED;
+        buf = fallback_buf;
     }
 
     int16_t ini_name_index = zai_config_initialize_ini_value(memoized->ini_entries, memoized->names_count, &value,

Original file line number	Diff line number	Diff line change
`@@ -99,9 +99,11 @@ static void zai_config_find_and_set_value(zai_config_memoized_entry *memoized, z`
`99`	`99`	`break;`
`100`	`100`	`}`
`101`	`101`	`}`
`102`		`- if (!value.len && memoized->env_config_fallback && memoized->env_config_fallback(&buf, true)) {`
`103`		`- zai_config_process_env(memoized, buf, &value);`
	`102`	`+ ZAI_ENV_BUFFER_INIT(fallback_buf, ZAI_ENV_MAX_BUFSIZ);`
	`103`	`+ if (!value.len && memoized->env_config_fallback && memoized->env_config_fallback(&fallback_buf, true)) {`
	`104`	`+ zai_config_process_env(memoized, fallback_buf, &value);`
`104`	`105`	`name_index = ZAI_CONFIG_ORIGIN_MODIFIED;`
	`106`	`+ buf = fallback_buf;`
`105`	`107`	`}`
`106`	`108`
`107`	`109`	`int16_t ini_name_index = zai_config_initialize_ini_value(memoized->ini_entries, memoized->names_count, &value,`