Skip to content

Commit 1c2af13

Browse files
bwoebiamarziali
authored andcommitted
Fix use-after-free in set_container_tags_hash test function
1 parent 309904c commit 1c2af13

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

tracer/functions.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1996,7 +1996,9 @@ PHP_FUNCTION(dd_trace_internal_fn) {
19961996
} else if (params_count == 1 && FUNCTION_NAME_MATCHES("set_container_tags_hash")) {
19971997
zval *container_tags_hash = ZVAL_VARARG_PARAM(params, 0);
19981998
if (Z_TYPE_P(container_tags_hash) == IS_STRING) {
1999-
datadog_process_tags_set_container_tags_hash(Z_STR_P(container_tags_hash));
1999+
zend_string *hash = zend_string_dup(Z_STR_P(container_tags_hash), 1);
2000+
datadog_process_tags_set_container_tags_hash(hash);
2001+
zend_string_release(hash);
20002002
RETVAL_TRUE;
20012003
} else {
20022004
RETVAL_FALSE;

0 commit comments

Comments
 (0)