fix(laravel): use route URI instead of unnamed_route in resource name (#3761)

Leiyks · web-flow · commit 1111e8073a94 · 2026-04-01T18:32:06.000+02:00
When DD_HTTP_SERVER_ROUTE_BASED_NAMING is enabled (default), routes
defined without a -&gt;name() call produced resources like:

  App\Http\Controllers\FooController@bar unnamed_route

This was unhelpful and inconsistent with named routes. For unnamed
routes, fall back to `{HTTP_METHOD} {route_uri}` (e.g. `GET error`),
which matches the format customers already see for named routes and
gives a meaningful, actionable resource name.

Named routes are unaffected.

Fixes APMS-18982
diff --git a/src/DDTrace/Integrations/Laravel/LaravelIntegration.php b/src/DDTrace/Integrations/Laravel/LaravelIntegration.php
@@ -122,7 +122,13 @@ static function ($This, $scope, $args, $route) {
                 $routeName = self::normalizeRouteName($route->getName());
 
                 if (dd_trace_env_config("DD_HTTP_SERVER_ROUTE_BASED_NAMING")) {
-                    $rootSpan->resource = $route->getActionName() . ' ' . $routeName;
+                    if ($routeName !== self::UNNAMED_ROUTE) {
+                        $rootSpan->resource = $route->getActionName() . ' ' . $routeName;
+                    } elseif (method_exists($route, 'uri')) {
+                        $rootSpan->resource = $route->getActionName() . ' ' . $route->uri();
+                    } else {
+                        $rootSpan->resource = $route->getActionName() . ' ' . self::UNNAMED_ROUTE;
+                    }
                 }
 
                 $rootSpan->meta['laravel.route.name'] = $routeName;
diff --git a/tests/Integrations/Laravel/V8_x/RouteCachingTest.php b/tests/Integrations/Laravel/V8_x/RouteCachingTest.php
@@ -36,7 +36,7 @@ public function testNotCached()
                     'laravel.request',
                     'Laravel',
                     'web',
-                    'App\Http\Controllers\RouteCachingController@unnamed unnamed_route'
+                    'App\Http\Controllers\RouteCachingController@unnamed unnamed-route'
                 )
                     ->withExactTags([
                         'laravel.route.name' => 'unnamed_route',
@@ -84,7 +84,7 @@ public function testCached()
                     'laravel.request',
                     'Laravel',
                     'web',
-                    'App\Http\Controllers\RouteCachingController@unnamed unnamed_route'
+                    'App\Http\Controllers\RouteCachingController@unnamed unnamed-route'
                 )
                     ->withExactTags([
                         'laravel.route.name' => 'unnamed_route',
diff --git a/tests/snapshots/tests.integrations.laravel.apigw_test.test_laravel_inferred_proxy_exception.json b/tests/snapshots/tests.integrations.laravel.apigw_test.test_laravel_inferred_proxy_exception.json
@@ -30,7 +30,7 @@
      {
        "name": "laravel.request",
        "service": "my_service",
-       "resource": "App\\Http\\Controllers\\CommonSpecsController@error unnamed_route",
+       "resource": "App\\Http\\Controllers\\CommonSpecsController@error error",
        "trace_id": 0,
        "span_id": 2,
        "parent_id": 1,
diff --git a/tests/snapshots/tests.integrations.laravel.latest.common_scenarios_test.test_scenario_get_with_exception.json b/tests/snapshots/tests.integrations.laravel.latest.common_scenarios_test.test_scenario_get_with_exception.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "my_service",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@error unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@error error",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 5879388483676493807,
diff --git a/tests/snapshots/tests.integrations.laravel.latest.common_scenarios_test.test_scenario_get_with_view.json b/tests/snapshots/tests.integrations.laravel.latest.common_scenarios_test.test_scenario_get_with_view.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "my_service",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@simple_view unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@simple_view simple_view",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 13950427361689200115,
diff --git a/tests/snapshots/tests.integrations.laravel.octane.apigw_test.test_inferred_proxy_exception.json b/tests/snapshots/tests.integrations.laravel.octane.apigw_test.test_inferred_proxy_exception.json
@@ -29,7 +29,7 @@
      {
        "name": "laravel.request",
        "service": "swoole_test_app",
-       "resource": "App\\Http\\Controllers\\CommonSpecsController@error unnamed_route",
+       "resource": "App\\Http\\Controllers\\CommonSpecsController@error error",
        "trace_id": 0,
        "span_id": 2,
        "parent_id": 1,
diff --git a/tests/snapshots/tests.integrations.laravel.v10_x.common_scenarios_test.test_scenario_get_with_exception.json b/tests/snapshots/tests.integrations.laravel.v10_x.common_scenarios_test.test_scenario_get_with_exception.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "my_service",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@error unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@error error",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 14785377647724168590,
diff --git a/tests/snapshots/tests.integrations.laravel.v10_x.common_scenarios_test.test_scenario_get_with_view.json b/tests/snapshots/tests.integrations.laravel.v10_x.common_scenarios_test.test_scenario_get_with_view.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "my_service",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@simple_view unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@simple_view simple_view",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 833116231812134410,
diff --git a/tests/snapshots/tests.integrations.laravel.v11_x.common_scenarios_test.test_scenario_get_with_exception.json b/tests/snapshots/tests.integrations.laravel.v11_x.common_scenarios_test.test_scenario_get_with_exception.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "my_service",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@error unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@error error",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 7417571401826106684,
diff --git a/tests/snapshots/tests.integrations.laravel.v11_x.common_scenarios_test.test_scenario_get_with_view.json b/tests/snapshots/tests.integrations.laravel.v11_x.common_scenarios_test.test_scenario_get_with_view.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "my_service",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@simple_view unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@simple_view simple_view",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 11570399397149531429,
diff --git a/tests/snapshots/tests.integrations.laravel.v5_7.common_scenarios_test.test_scenario_get_dynamic_route.json b/tests/snapshots/tests.integrations.laravel.v5_7.common_scenarios_test.test_scenario_get_dynamic_route.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "laravel_test_app",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@dynamicRoute unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@dynamicRoute dynamic_route/{param01}/static/{param02?}",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 8491564511610816344,
diff --git a/tests/snapshots/tests.integrations.laravel.v5_7.common_scenarios_test.test_scenario_get_with_exception.json b/tests/snapshots/tests.integrations.laravel.v5_7.common_scenarios_test.test_scenario_get_with_exception.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "laravel_test_app",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@error unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@error error",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 11638207704594054193,
diff --git a/tests/snapshots/tests.integrations.laravel.v5_7.common_scenarios_test.test_scenario_get_with_view.json b/tests/snapshots/tests.integrations.laravel.v5_7.common_scenarios_test.test_scenario_get_with_view.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "laravel_test_app",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@simple_view unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@simple_view simple_view",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 17417893670227081443,
diff --git a/tests/snapshots/tests.integrations.laravel.v5_8.common_scenarios_test.test_scenario_get_dynamic_route.json b/tests/snapshots/tests.integrations.laravel.v5_8.common_scenarios_test.test_scenario_get_dynamic_route.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "laravel_test_app",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@dynamicRoute unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@dynamicRoute dynamic_route/{param01}/static/{param02?}",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 16982091743140843000,
diff --git a/tests/snapshots/tests.integrations.laravel.v5_8.common_scenarios_test.test_scenario_get_with_exception.json b/tests/snapshots/tests.integrations.laravel.v5_8.common_scenarios_test.test_scenario_get_with_exception.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "laravel_test_app",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@error unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@error error",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 2860973756877146746,
diff --git a/tests/snapshots/tests.integrations.laravel.v5_8.common_scenarios_test.test_scenario_get_with_view.json b/tests/snapshots/tests.integrations.laravel.v5_8.common_scenarios_test.test_scenario_get_with_view.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "laravel_test_app",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@simple_view unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@simple_view simple_view",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 12604606052329515364,
diff --git a/tests/snapshots/tests.integrations.laravel.v8_x.common_scenarios_test.test_scenario_get_dynamic_route.json b/tests/snapshots/tests.integrations.laravel.v8_x.common_scenarios_test.test_scenario_get_dynamic_route.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "laravel_test_app",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@dynamicRoute unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@dynamicRoute dynamic_route/{param01}/static/{param02?}",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 619982517647425679,
diff --git a/tests/snapshots/tests.integrations.laravel.v8_x.common_scenarios_test.test_scenario_get_with_exception.json b/tests/snapshots/tests.integrations.laravel.v8_x.common_scenarios_test.test_scenario_get_with_exception.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "laravel_test_app",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@error unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@error error",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 13974093062283399257,
diff --git a/tests/snapshots/tests.integrations.laravel.v8_x.common_scenarios_test.test_scenario_get_with_view.json b/tests/snapshots/tests.integrations.laravel.v8_x.common_scenarios_test.test_scenario_get_with_view.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "laravel_test_app",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@simple_view unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@simple_view simple_view",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 11697810065757930131,
diff --git a/tests/snapshots/tests.integrations.laravel.v9_x.common_scenarios_test.test_scenario_get_with_exception.json b/tests/snapshots/tests.integrations.laravel.v9_x.common_scenarios_test.test_scenario_get_with_exception.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "my_service",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@error unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@error error",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 12507063039839161923,
diff --git a/tests/snapshots/tests.integrations.laravel.v9_x.common_scenarios_test.test_scenario_get_with_view.json b/tests/snapshots/tests.integrations.laravel.v9_x.common_scenarios_test.test_scenario_get_with_view.json
@@ -2,7 +2,7 @@
   {
     "name": "laravel.request",
     "service": "my_service",
-    "resource": "App\\Http\\Controllers\\CommonSpecsController@simple_view unnamed_route",
+    "resource": "App\\Http\\Controllers\\CommonSpecsController@simple_view simple_view",
     "trace_id": 0,
     "span_id": 1,
     "parent_id": 460992100878085912,

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@`
`30`	`30`	`{`
`31`	`31`	`"name": "laravel.request",`
`32`	`32`	`"service": "my_service",`
`33`		`- "resource": "App\\Http\\Controllers\\CommonSpecsController@error unnamed_route",`
	`33`	`+ "resource": "App\\Http\\Controllers\\CommonSpecsController@error error",`
`34`	`34`	`"trace_id": 0,`
`35`	`35`	`"span_id": 2,`
`36`	`36`	`"parent_id": 1,`
Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`	`{`
`3`	`3`	`"name": "laravel.request",`
`4`	`4`	`"service": "my_service",`
`5`		`- "resource": "App\\Http\\Controllers\\CommonSpecsController@error unnamed_route",`
	`5`	`+ "resource": "App\\Http\\Controllers\\CommonSpecsController@error error",`
`6`	`6`	`"trace_id": 0,`
`7`	`7`	`"span_id": 1,`
`8`	`8`	`"parent_id": 5879388483676493807,`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@`
`29`	`29`	`{`
`30`	`30`	`"name": "laravel.request",`
`31`	`31`	`"service": "swoole_test_app",`
`32`		`- "resource": "App\\Http\\Controllers\\CommonSpecsController@error unnamed_route",`
	`32`	`+ "resource": "App\\Http\\Controllers\\CommonSpecsController@error error",`
`33`	`33`	`"trace_id": 0,`
`34`	`34`	`"span_id": 2,`
`35`	`35`	`"parent_id": 1,`