Adjust comments

bwoebi · bwoebi · commit 0aefc97d5164 · 2026-04-27T12:19:03.000+02:00
diff --git a/ext/process_tags.c b/ext/process_tags.c
@@ -55,9 +55,7 @@ static void clear_process_tags(void) {
     }
 
     if (process_tags.serialized) {
-        // Counterpart to the IS_STR_INTERNED flag set in serialize_process_tags:
-        // zend_string_release no-ops on interned strings, so clear the flag
-        // first to actually free the underlying persistent allocation.
+        // Counterpart to the IS_STR_INTERNED flag set in serialize_process_tags
         GC_DEL_FLAGS(process_tags.serialized, IS_STR_INTERNED);
         zend_string_release(process_tags.serialized);
     }
@@ -259,11 +257,7 @@ static void serialize_process_tags(void) {
     if (buf.s) {
         smart_str_0(&buf);
         process_tags.serialized = zend_string_init(ZSTR_VAL(buf.s), ZSTR_LEN(buf.s), 1);
-        // Process-wide shared string: pre-compute h (interned strings are
-        // expected to have it set; callers may read ZSTR_H() raw) then mark
-        // interned (= GC_IMMUTABLE) so the convert_to_bytes refcount helpers
-        // skip the non-atomic ++/-- that would otherwise race across ZTS
-        // threads.
+        // Intern to avoid races with string touched by refcounting; but just the flag, no need for the whole persisting ceremony
         zend_string_hash_val(process_tags.serialized);
         GC_ADD_FLAGS(process_tags.serialized, IS_STR_INTERNED);
     }
