Skip to content

Commit 07b618a

Browse files
morrisonlevimorrisonlevi
authored
test(ci): skip phpinfo language test on PHP <=8.1 (#3674)
phpinfo.phpt on PHP 7.0-8.1 use older %A/%a expectations. With large phpinfo() output (tracer modules + CI environment variables), those patterns can hit regex backtracking issues and then the diff fails to match cleanly.
1 parent 55cce7c commit 07b618a

8 files changed

Lines changed: 14 additions & 0 deletions

File tree

‎dockerfiles/ci/xfail_tests/7.0.list‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -347,6 +347,7 @@ ext/standard/tests/general_functions/bug35229.phpt
347347
ext/standard/tests/general_functions/bug73973.phpt
348348
ext/standard/tests/general_functions/get_included_files.phpt
349349
ext/standard/tests/general_functions/gettype_settype_basic.phpt
350+
ext/standard/tests/general_functions/phpinfo.phpt
350351
ext/standard/tests/general_functions/print_r_64bit.phpt
351352
ext/standard/tests/general_functions/strval.phpt
352353
ext/standard/tests/general_functions/type.phpt

‎dockerfiles/ci/xfail_tests/7.1.list‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -375,6 +375,7 @@ ext/standard/tests/general_functions/bug35229.phpt
375375
ext/standard/tests/general_functions/bug73973.phpt
376376
ext/standard/tests/general_functions/get_included_files.phpt
377377
ext/standard/tests/general_functions/gettype_settype_basic.phpt
378+
ext/standard/tests/general_functions/phpinfo.phpt
378379
ext/standard/tests/general_functions/print_r_64bit.phpt
379380
ext/standard/tests/general_functions/strval.phpt
380381
ext/standard/tests/general_functions/type.phpt

‎dockerfiles/ci/xfail_tests/7.2.list‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -331,6 +331,7 @@ ext/standard/tests/file/lstat_stat_variation10.phpt
331331
ext/standard/tests/general_functions/bug73973.phpt
332332
ext/standard/tests/general_functions/get_included_files.phpt
333333
ext/standard/tests/general_functions/gettype_settype_basic.phpt
334+
ext/standard/tests/general_functions/phpinfo.phpt
334335
ext/standard/tests/general_functions/print_r_64bit.phpt
335336
ext/standard/tests/general_functions/strval.phpt
336337
ext/standard/tests/general_functions/type.phpt

‎dockerfiles/ci/xfail_tests/7.3.list‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -345,6 +345,7 @@ ext/standard/tests/file/lstat_stat_variation10.phpt
345345
ext/standard/tests/general_functions/bug73973.phpt
346346
ext/standard/tests/general_functions/get_included_files.phpt
347347
ext/standard/tests/general_functions/gettype_settype_basic.phpt
348+
ext/standard/tests/general_functions/phpinfo.phpt
348349
ext/standard/tests/general_functions/print_r_64bit.phpt
349350
ext/standard/tests/general_functions/strval.phpt
350351
ext/standard/tests/general_functions/type.phpt

‎dockerfiles/ci/xfail_tests/7.4.list‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -406,6 +406,7 @@ ext/standard/tests/file/lstat_stat_variation15.phpt
406406
ext/standard/tests/general_functions/bug73973.phpt
407407
ext/standard/tests/general_functions/get_included_files.phpt
408408
ext/standard/tests/general_functions/gettype_settype_basic.phpt
409+
ext/standard/tests/general_functions/phpinfo.phpt
409410
ext/standard/tests/general_functions/print_r_64bit.phpt
410411
ext/standard/tests/general_functions/proc_open_null.phpt
411412
ext/standard/tests/general_functions/proc_open_redirect.phpt

‎dockerfiles/ci/xfail_tests/8.0.list‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -470,6 +470,7 @@ ext/standard/tests/general_functions/floatval.phpt
470470
ext/standard/tests/general_functions/floatval_variation1.phpt
471471
ext/standard/tests/general_functions/get_included_files.phpt
472472
ext/standard/tests/general_functions/gettype_settype_basic.phpt
473+
ext/standard/tests/general_functions/phpinfo.phpt
473474
ext/standard/tests/general_functions/print_r.phpt
474475
ext/standard/tests/general_functions/print_r_64bit.phpt
475476
ext/standard/tests/general_functions/proc_open_null.phpt

‎dockerfiles/ci/xfail_tests/8.1.list‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -170,6 +170,7 @@ ext/standard/tests/general_functions/floatval.phpt
170170
ext/standard/tests/general_functions/floatval_variation1.phpt
171171
ext/standard/tests/general_functions/get_included_files.phpt
172172
ext/standard/tests/general_functions/gettype_settype_basic.phpt
173+
ext/standard/tests/general_functions/phpinfo.phpt
173174
ext/standard/tests/general_functions/print_r.phpt
174175
ext/standard/tests/general_functions/print_r_64bit.phpt
175176
ext/standard/tests/general_functions/proc_open_null.phpt

‎dockerfiles/ci/xfail_tests/README.md‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,13 @@ Such tests were skipped before and are incredibly unstable on 5. It might be a C
150150

151151
This test was flaky until it was [fixed in PHP 7.2](https://github.com/php/php-src/commit/f4474e5).
152152

153+
## `ext/standard/tests/general_functions/phpinfo.phpt`
154+
155+
* Disabled on versions: `7.0 --> 8.1`.
156+
* Upstream fix: [Reduce regex backtracking in phpinfo.phpt](https://github.com/php/php-src/commit/c4c45da4b96889348d86828c26225d113af14d21), which is present in PHP 8.2+.
157+
158+
This test compares very large `phpinfo()` output. With tracer-specific modules and CI environment variables enabled, the output grows and older `%A`/`%a` patterns in this test can hit pathological backtracking and fail nondeterministically.
159+
153160
## `ext/standard/tests/streams/proc_open_bug69900.phpt`
154161

155162
* Disabled on versions: `7.0+`.

0 commit comments

Comments
 (0)