fix(test-optimization): wait for all worker writers#9349
Conversation
This prevents coverage, logs, or telemetry payloads from being lost when traces flush before their IPC sends complete.
Overall package sizeSelf size: 6.74 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.1 | 122.62 kB | 438.86 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
|
BenchmarksBenchmark execution time: 2026-07-14 18:43:08 Comparing candidate commit 2d8740e in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2309 metrics, 49 unstable metrics.
|
There was a problem hiding this comment.
More details
The PR correctly implements awaiting all writer flushes before signaling completion. The counter-based coordination handles mixed sync/async callbacks properly, and all edge cases (no telemetry writer, multiple flushes, empty payloads) are handled correctly. Tests comprehensively validate the new callback coordination logic.
📊 Validated against 6 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit 2d8740e · What is Autotest? · Any feedback? Reach out in #autotest
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9349 +/- ##
==========================================
- Coverage 96.61% 96.11% -0.51%
==========================================
Files 920 920
Lines 122387 122408 +21
Branches 21592 20702 -890
==========================================
- Hits 118249 117647 -602
- Misses 4138 4761 +623 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This prevents coverage, logs, or telemetry payloads from being lost when traces flush before their IPC sends complete.
This prevents coverage, logs, or telemetry payloads from being lost when traces flush before their IPC sends complete.
Summary
The worker flush callback now waits for trace, coverage, log, and telemetry payloads to complete.