Skip to content

test: prepare lint and Vitest for TypeScript 7#9345

Merged
BridgeAR merged 2 commits into
masterfrom
BridgeAR/2026-07-14-typescript-7-compat
Jul 14, 2026
Merged

test: prepare lint and Vitest for TypeScript 7#9345
BridgeAR merged 2 commits into
masterfrom
BridgeAR/2026-07-14-typescript-7-compat

Conversation

@BridgeAR

Copy link
Copy Markdown
Member

Summary

TypeScript 7 exposes two compatibility issues before the dependency update can land. SonarJS 4.1 crashes while loading compiler enums that TypeScript 7 removed, and Vitest 3 picks up the repository tsc from npm's inherited PATH instead of the sandbox's pinned compiler. This updates SonarJS to the release that pins a compatible compiler and makes the Vitest fixture invoke its sandboxed tsc directly.

Refs: #9327

BridgeAR added 2 commits July 14, 2026 19:31
SonarJS 4.1 reads compiler enums removed in TypeScript 7 and crashes before ESLint can run.
Vitest 3 resolves a bare tsc command from the inherited npm PATH, which made sandboxed typechecks use the repository compiler instead of their pinned dependency.
@BridgeAR
BridgeAR requested review from a team as code owners July 14, 2026 17:37
@dd-octo-sts

dd-octo-sts Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Overall package size

Self size: 6.74 MB
Deduped: 7.4 MB
No deduping: 7.4 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.1 | 122.62 kB | 438.86 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@datadog-prod-us1-6 datadog-prod-us1-6 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

PR is a correct preparation for TypeScript 7 compatibility: updates sonarjs to pin a TS-compatible version and makes Vitest's typecheck use the sandboxed tsc directly instead of PATH resolution. Both changes are minimal, necessary, and carry no behavioral risks.

Was this helpful? React 👍 or 👎

📊 Validated against 4 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit aae8006 · What is Autotest? · Any feedback? Reach out in #autotest

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Jul 14, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 96.58% (+0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: aae8006 | Docs | Datadog PR Page | Give us feedback!

@pr-commenter

pr-commenter Bot commented Jul 14, 2026

Copy link
Copy Markdown

Benchmarks

Benchmark execution time: 2026-07-14 17:52:29

Comparing candidate commit aae8006 in PR branch BridgeAR/2026-07-14-typescript-7-compat with baseline commit c5edb32 in branch master.

📊 Benchmarking dashboard

Found 0 performance improvements and 0 performance regressions! Performance is the same for 2310 metrics, 48 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Unstable benchmarks

These benchmarks have a confidence interval too wide to call a change; treat them as noise rather than signal.

scenario:appsec-appsec-enabled-24

  • unstable execution_time [-218.910ms; +214.281ms] or [-8.237%; +8.062%]

scenario:appsec-appsec-enabled-26

  • unstable execution_time [-251.769ms; +242.390ms] or [-9.858%; +9.491%]

scenario:appsec-appsec-enabled-with-attacks-24

  • unstable execution_time [-161.433ms; +164.940ms] or [-5.155%; +5.267%]

scenario:appsec-appsec-enabled-with-attacks-26

  • unstable execution_time [-194676.986µs; +193598.586µs] or [-6.720%; +6.683%]

scenario:appsec-control-20

  • unstable execution_time [-119.429ms; +125.327ms] or [-7.263%; +7.622%]

scenario:appsec-control-24

  • unstable execution_time [-115.500ms; +119.523ms] or [-9.306%; +9.630%]

scenario:appsec-control-26

  • unstable execution_time [-124410.342µs; +125257.275µs] or [-10.065%; +10.133%]

scenario:appsec-iast-no-vulnerability-control-20

  • unstable execution_time [-12.936ms; +15.736ms] or [-5.019%; +6.105%]

scenario:appsec-iast-no-vulnerability-iast-enabled-always-active-20

  • unstable execution_time [-14177.619µs; +15935.952µs] or [-5.492%; +6.173%]

scenario:appsec-iast-no-vulnerability-iast-enabled-default-config-20

  • unstable execution_time [-13.432ms; +16.543ms] or [-5.318%; +6.549%]

scenario:appsec-iast-with-vulnerability-iast-enabled-default-config-20

  • unstable execution_time [-26.876ms; +33.524ms] or [-4.897%; +6.108%]

scenario:child_process-shell-string-24

  • unstable execution_time [-11.407ms; +24.575ms] or [-3.420%; +7.367%]

scenario:debugger-line-probe-with-snapshot-default-24

  • unstable cpu_user_time [-1602.969ms; +2636.285ms] or [-18.873%; +31.040%]
  • unstable execution_time [-1591.169ms; +2638.351ms] or [-17.282%; +28.656%]
  • unstable instructions [-13.7G instructions; +22.4G instructions] or [-19.718%; +32.362%]
  • unstable max_rss_usage [-6.492MB; +10.254MB] or [-4.139%; +6.538%]
  • unstable throughput [-734.073op/s; +434.682op/s] or [-20.673%; +12.242%]

scenario:debugger-line-probe-with-snapshot-minimal-24

  • unstable cpu_user_time [-1872.122ms; +309.710ms] or [-22.103%; +3.657%]
  • unstable execution_time [-1906.689ms; +320.664ms] or [-20.722%; +3.485%]
  • unstable instructions [-16.2G instructions; +2.8G instructions] or [-23.333%; +3.996%]
  • unstable throughput [-61.931op/s; +553.355op/s] or [-1.734%; +15.494%]

scenario:debugger-line-probe-with-snapshot-minimal-26

  • unstable cpu_user_time [-3665.566ms; +3657.145ms] or [-35.659%; +35.577%]
  • unstable execution_time [-3833.736ms; +3799.404ms] or [-34.817%; +34.506%]
  • unstable instructions [-32383.4M instructions; +32203.7M instructions] or [-37.433%; +37.225%]
  • unstable max_rss_usage [-11346.457KB; +11781.657KB] or [-6.982%; +7.250%]
  • unstable throughput [-742.205op/s; +749.225op/s] or [-23.933%; +24.159%]

scenario:debugger-line-probe-without-snapshot-24

  • unstable cpu_user_time [-2121.423ms; +3601.628ms] or [-22.517%; +38.228%]
  • unstable execution_time [-2147.407ms; +3605.051ms] or [-21.144%; +35.496%]
  • unstable instructions [-18.3G instructions; +30.6G instructions] or [-23.726%; +39.620%]
  • unstable max_rss_usage [-10.292MB; +14.590MB] or [-6.377%; +9.039%]
  • unstable throughput [-996.852op/s; +540.979op/s] or [-30.022%; +16.292%]

scenario:debugger-line-probe-without-snapshot-26

  • unstable cpu_user_time [-3679.815ms; +3650.343ms] or [-35.761%; +35.475%]
  • unstable execution_time [-3728.434ms; +3702.092ms] or [-33.901%; +33.662%]
  • unstable instructions [-32292.9M instructions; +32273.6M instructions] or [-37.340%; +37.318%]
  • unstable max_rss_usage [-10609.472KB; +11625.472KB] or [-6.538%; +7.164%]
  • unstable throughput [-734.346op/s; +728.802op/s] or [-23.689%; +23.510%]

scenario:dogstatsd-with-tags-20

  • unstable cpu_user_time [-327.085ms; +310.867ms] or [-6.803%; +6.466%]
  • unstable execution_time [-324.908ms; +313.732ms] or [-6.625%; +6.397%]
  • unstable throughput [-103037.181op/s; +119014.192op/s] or [-6.051%; +6.989%]

scenario:plugin-graphql-long-with-depth-and-collapse-off-20

  • unstable max_rss_usage [-18.449MB; +30.106MB] or [-4.933%; +8.050%]

scenario:plugin-graphql-long-with-depth-on-max-20

  • unstable cpu_user_time [-694.503ms; +740.762ms] or [-5.401%; +5.761%]
  • unstable execution_time [-700.069ms; +746.386ms] or [-5.328%; +5.680%]
  • unstable throughput [-3.443op/s; +3.218op/s] or [-5.621%; +5.253%]

scenario:plugin-memcached-hashring-24

  • unstable execution_time [-129.463ms; +151.751ms] or [-5.048%; +5.917%]

scenario:plugin-pg-service-26

  • unstable cpu_usage_percentage [-10.776%; +7.013%]
  • unstable execution_time [-105.606ms; +165.803ms] or [-11.669%; +18.321%]
  • unstable throughput [-775056.162op/s; +494233.023op/s] or [-11.425%; +7.285%]

scenario:test-optimization-large-suite-20

  • unstable max_rss_usage [-3957.022KB; +4231.022KB] or [-4.981%; +5.325%]

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.61%. Comparing base (c5edb32) to head (aae8006).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #9345    +/-   ##
========================================
  Coverage   96.61%   96.61%            
========================================
  Files         920      920            
  Lines      122387   122387            
  Branches    20958    21511   +553     
========================================
+ Hits       118247   118249     +2     
+ Misses       4140     4138     -2     
Flag Coverage Δ
aiguard 53.55% <ø> (-0.05%) ⬇️
aiguard-integration 56.97% <ø> (ø)
apm-bucket-0 53.78% <ø> (-0.05%) ⬇️
apm-bucket-1 58.05% <ø> (-0.05%) ⬇️
apm-bucket-2 56.10% <ø> (-0.05%) ⬇️
apm-capabilities-tracing 60.33% <ø> (ø)
apm-integrations-aerospike 52.92% <ø> (-0.05%) ⬇️
apm-integrations-confluentinc-kafka-javascript 56.98% <ø> (-0.12%) ⬇️
apm-integrations-couchbase 53.26% <ø> (-0.05%) ⬇️
apm-integrations-http 57.94% <ø> (-0.05%) ⬇️
apm-integrations-kafkajs 57.69% <ø> (-0.05%) ⬇️
apm-integrations-next 54.23% <ø> (-0.05%) ⬇️
apm-integrations-prisma 54.16% <ø> (-0.05%) ⬇️
apm-integrations-tedious 53.03% <ø> (-0.05%) ⬇️
appsec 68.97% <ø> (+0.01%) ⬆️
appsec-express_fastify_graphql 65.67% <ø> (-0.03%) ⬇️
appsec-integration 51.89% <ø> (ø)
appsec-kafka_ldapjs_lodash 59.07% <ø> (-0.04%) ⬇️
appsec-mongodb-core_mongoose_mysql 62.22% <ø> (-0.04%) ⬇️
appsec-next 52.84% <ø> (-0.04%) ⬇️
appsec-node-serialize_passport_postgres 61.85% <ø> (-0.04%) ⬇️
appsec-sourcing_stripe_template 60.31% <ø> (-0.04%) ⬇️
debugger 65.72% <ø> (-0.04%) ⬇️
instrumentations-bucket-0 48.75% <ø> (-0.05%) ⬇️
instrumentations-bucket-1 54.95% <ø> (-0.05%) ⬇️
instrumentations-bucket-10 56.61% <ø> (-0.05%) ⬇️
instrumentations-bucket-11 48.74% <ø> (-0.05%) ⬇️
instrumentations-bucket-12 48.85% <ø> (-0.05%) ⬇️
instrumentations-bucket-13 48.68% <ø> (-0.05%) ⬇️
instrumentations-bucket-2 49.74% <ø> (-0.05%) ⬇️
instrumentations-bucket-3 53.82% <ø> (-0.05%) ⬇️
instrumentations-bucket-4 49.16% <ø> (-0.05%) ⬇️
instrumentations-bucket-5 53.00% <ø> (-0.05%) ⬇️
instrumentations-bucket-6 55.58% <ø> (-0.05%) ⬇️
instrumentations-bucket-7 53.59% <ø> (-0.05%) ⬇️
instrumentations-bucket-8 54.63% <ø> (-0.05%) ⬇️
instrumentations-bucket-9 56.08% <ø> (-0.04%) ⬇️
instrumentations-instrumentation-couchbase 48.13% <ø> (-0.05%) ⬇️
instrumentations-integration-esbuild 33.89% <ø> (ø)
llmobs-ai_anthropic_bedrock 57.73% <ø> (-0.04%) ⬇️
llmobs-bucket-1 57.00% <ø> (-0.04%) ⬇️
llmobs-openai 57.39% <ø> (-0.04%) ⬇️
llmobs-sdk 59.96% <ø> (-0.05%) ⬇️
llmobs-vertex-ai 54.22% <ø> (-0.05%) ⬇️
master-coverage 96.61% <ø> (?)
openfeature 54.59% <ø> (ø)
openfeature-unit 49.78% <ø> (-0.05%) ⬇️
platform-core_esbuild_instrumentations-misc 38.37% <ø> (-0.03%) ⬇️
platform-integration 62.33% <ø> (ø)
platform-shimmer_unit-guardrails_webpack 37.20% <ø> (-0.03%) ⬇️
plugins-bucket-0 53.17% <ø> (-0.05%) ⬇️
plugins-bucket-1 55.02% <ø> (ø)
plugins-bucket-11 57.49% <ø> (-0.05%) ⬇️
plugins-bucket-18 56.98% <ø> (-0.05%) ⬇️
plugins-bucket-19 55.34% <ø> (-0.05%) ⬇️
plugins-bucket-20 57.59% <ø> (-0.05%) ⬇️
plugins-bucket-4 53.84% <ø> (-0.05%) ⬇️
plugins-bullmq_cassandra_cookie 57.34% <ø> (-0.05%) ⬇️
plugins-cookie-parser_crypto_dd-trace-api 52.31% <ø> (-0.05%) ⬇️
plugins-fetch_fs_generic-pool 54.45% <ø> (-0.05%) ⬇️
plugins-google-cloud-pubsub_grpc_handlebars 59.84% <ø> (-0.05%) ⬇️
plugins-hapi_hono_ioredis 55.84% <ø> (-0.05%) ⬇️
plugins-jest_knex_langgraph 51.66% <ø> (-0.05%) ⬇️
plugins-ldapjs_light-my-request_limitd-client 53.43% <ø> (-0.03%) ⬇️
plugins-lodash_mariadb_memcached 54.20% <ø> (-0.05%) ⬇️
plugins-moleculer_mongodb_mongodb-core 57.28% <ø> (-0.05%) ⬇️
plugins-mongoose_multer_mysql 54.69% <ø> (-0.05%) ⬇️
plugins-mysql2_nats_node-serialize 56.19% <ø> (-0.05%) ⬇️
plugins-opensearch_passport-http_pino 55.04% <ø> (-0.05%) ⬇️
plugins-postgres_process_pug 54.28% <ø> (-0.05%) ⬇️
plugins-redis_router_sequelize 57.01% <ø> (-0.05%) ⬇️
plugins-test-and-upstream-rhea_undici_url 56.99% <ø> (-0.07%) ⬇️
plugins-valkey_vm_winston 53.92% <ø> (-0.05%) ⬇️
plugins-ws 54.78% <ø> (-0.04%) ⬇️
profiling 58.20% <ø> (-0.04%) ⬇️
serverless-aws-sdk-aws-sdk 50.66% <ø> (-0.04%) ⬇️
serverless-aws-sdk-bedrockruntime 50.68% <ø> (-0.05%) ⬇️
serverless-aws-sdk-client 51.93% <ø> (-0.05%) ⬇️
serverless-aws-sdk-dynamodb 51.75% <ø> (-0.05%) ⬇️
serverless-aws-sdk-eventbridge 46.22% <ø> (-0.05%) ⬇️
serverless-aws-sdk-kinesis 54.70% <ø> (-0.05%) ⬇️
serverless-aws-sdk-lambda 52.78% <ø> (-0.05%) ⬇️
serverless-aws-sdk-s3 51.53% <ø> (-0.05%) ⬇️
serverless-aws-sdk-serverless-peer-service 54.71% <ø> (-0.05%) ⬇️
serverless-aws-sdk-sns 55.47% <ø> (-0.05%) ⬇️
serverless-aws-sdk-sqs 55.90% <ø> (-0.05%) ⬇️
serverless-aws-sdk-stepfunctions 51.25% <ø> (-0.05%) ⬇️
serverless-aws-sdk-util 48.43% <ø> (-0.05%) ⬇️
serverless-bucket-0 55.17% <ø> (ø)
serverless-bucket-1 56.00% <ø> (-0.05%) ⬇️
test-optimization-cucumber 72.92% <ø> (-0.04%) ⬇️
test-optimization-cypress 66.29% <ø> (+0.01%) ⬆️
test-optimization-jest 74.22% <ø> (-0.05%) ⬇️
test-optimization-mocha 74.66% <ø> (+0.04%) ⬆️
test-optimization-playwright-playwright-atr 61.53% <ø> (-0.01%) ⬇️
test-optimization-playwright-playwright-efd 61.72% <ø> (+0.06%) ⬆️
test-optimization-playwright-playwright-final-status 61.70% <ø> (-0.01%) ⬇️
test-optimization-playwright-playwright-impacted-tests 61.41% <ø> (+0.16%) ⬆️
test-optimization-playwright-playwright-reporting 61.30% <ø> (-0.01%) ⬇️
test-optimization-playwright-playwright-test-management 62.27% <ø> (-0.12%) ⬇️
test-optimization-playwright-playwright-test-span 61.44% <ø> (-0.06%) ⬇️
test-optimization-selenium 60.64% <ø> (-0.11%) ⬇️
test-optimization-testopt 59.13% <ø> (+0.08%) ⬆️
test-optimization-vitest 71.46% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BridgeAR
BridgeAR merged commit 5515d3e into master Jul 14, 2026
660 checks passed
@BridgeAR
BridgeAR deleted the BridgeAR/2026-07-14-typescript-7-compat branch July 14, 2026 18:55
This was referenced Jul 15, 2026
juan-fernandez pushed a commit that referenced this pull request Jul 16, 2026
* chore(deps-dev): update sonarjs for TypeScript 7

SonarJS 4.1 reads compiler enums removed in TypeScript 7 and crashes before ESLint can run.

* test(vitest): use the sandboxed TypeScript compiler

Vitest 3 resolves a bare tsc command from the inherited npm PATH, which made sandboxed typechecks use the repository compiler instead of their pinned dependency.
juan-fernandez pushed a commit that referenced this pull request Jul 16, 2026
* chore(deps-dev): update sonarjs for TypeScript 7

SonarJS 4.1 reads compiler enums removed in TypeScript 7 and crashes before ESLint can run.

* test(vitest): use the sandboxed TypeScript compiler

Vitest 3 resolves a bare tsc command from the inherited npm PATH, which made sandboxed typechecks use the repository compiler instead of their pinned dependency.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants