fix(test-optimization): preserve zero EFD retry budgets#9341
Conversation
Falsy fallback logic replaced an explicit zero retry budget with defaults, scheduling retries the backend disabled.
Overall package sizeSelf size: 6.77 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | import-in-the-middle | 3.3.1 | 122.62 kB | 438.86 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | dc-polyfill | 0.1.11 | 25.74 kB | 25.74 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
🎉 All green!🧪 All tests passed 🔄 Datadog retried 2 tests - 2 passed on retry 🎯 Code Coverage (details) 🔗 Commit SHA: fbadc6d | Docs | Datadog PR Page | Give us feedback! |
There was a problem hiding this comment.
More details
All-zero EFD retry budgets are now correctly preserved instead of being replaced with defaults, preventing unwanted test retries when the backend explicitly disables retries. The fix uses nullish coalescing (??) to distinguish zero from undefined, and getMaxEfdRetryCount() now returns undefined for empty configurations. All six retry-count tests pass, including new tests that lock in the correct zero-preservation behavior.
📊 Validated against 10 scenarios · Open Bits AI session
🤖 Datadog Autotest · Commit fbadc6d · What is Autotest? · Any feedback? Reach out in #autotest
BenchmarksBenchmark execution time: 2026-07-14 16:49:12 Comparing candidate commit fbadc6d in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 2320 metrics, 38 unstable metrics.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #9341 +/- ##
==========================================
+ Coverage 96.61% 96.66% +0.05%
==========================================
Files 920 923 +3
Lines 122236 122939 +703
Branches 21070 21598 +528
==========================================
+ Hits 118097 118845 +748
+ Misses 4139 4094 -45
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
does only cucumber need fixes and an integration test for this bug? |
juan-fernandez
left a comment
There was a problem hiding this comment.
sry, I want to run a quick codex review
|
@codex review |
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Falsy fallback logic replaced an explicit zero retry budget with defaults, scheduling retries the backend disabled.
Falsy fallback logic replaced an explicit zero retry budget with defaults, scheduling retries the backend disabled.
Falsy fallback logic replaced an explicit zero retry budget with defaults, scheduling retries the backend disabled.
Falsy fallback logic replaced an explicit zero retry budget with defaults, scheduling retries the backend disabled.
Summary
Falsy fallback logic replaced explicit zero EFD retry budgets with defaults, scheduling retries the backend disabled.
Test plan